Skip to content

Fix an issue with GraphTool interval arrows at infinity disappearing. #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstaabp merged 1 commit into from
Sep 21, 2026
Merged

Fix an issue with GraphTool interval arrows at infinity disappearing. #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions htdocs/js/GraphTool/intervaltools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
this.setFocusBlurPointAttributes(point);
point.text?.setAttribute({ fontSize: 19, highlight: false, strokeColor: gt.color.curve });
point.arrow?.setAttribute({ strokeWidth: 4 });
point.arrow?.rendNodeTriangleEnd.setAttribute('fill', gt.color.curve);
if (point.arrow) point.arrow.rendNodeTriangleEnd.style.fill = gt.color.curve;
point.off('over');
point.off('out');
point.text?.off('down');
Expand Down Expand Up @@ -170,15 +170,17 @@
// The default layer for lines (of which arrows are a part) is 7.
// Setting this moves the arrow to the front of arrows of other intervals.
point.arrow?.setAttribute({ strokeWidth: 5, layer: 7 });
point.arrow?.rendNodeTriangleEnd.setAttribute('fill', gt.color.point);
if (point.arrow) point.arrow.rendNodeTriangleEnd.style.fill = gt.color.point;

// This makes it so that if the pointer is over the point and it is a hidden point at
// infinity, then it looks like the pointer is over the arrow. The end arrows don't
// actually receive hover events, so this has to be done this way.
point.on('over', () =>
point.arrow?.rendNodeTriangleEnd.setAttribute('fill', gt.color.pointHighlightDarker)
);
point.on('out', () => point.arrow?.rendNodeTriangleEnd.setAttribute('fill', gt.color.point));
point.on('over', () => {
if (point.arrow) point.arrow.rendNodeTriangleEnd.style.fill = gt.color.pointHighlightDarker;
});
point.on('out', () => {
if (point.arrow) point.arrow.rendNodeTriangleEnd.style.fill = gt.color.point;
});

point.text?.on('down', () => {
point.text.setAttribute({
Expand Down Expand Up @@ -349,11 +351,11 @@
aria: { enabled: true, hidden: true, live: 'off' }
}
);
this.definingPts[index].arrow.rendNodeTriangleEnd.setAttribute('fill', gt.color.curve);
this.definingPts[index].arrow.rendNodeTriangleEnd.style.fill = gt.color.curve;
}

if (this.focused && this.definingPts[index] === this.focusPoint) {
this.definingPts[index].arrow.rendNodeTriangleEnd.setAttribute('fill', gt.color.point);
this.definingPts[index].arrow.rendNodeTriangleEnd.style.fill = gt.color.point;
this.definingPts[index].arrow.setAttribute({ strokeWidth: 5 });
}
}
Expand Down Expand Up @@ -854,7 +856,8 @@
// The default layer for lines (of which arrows are a part) is 7.
// Setting this moves the arrow to the front of the segment created after it.
this.hlObjs.hl_arrow?.setAttribute({ layer: 7 });
this.hlObjs.hl_arrow?.rendNodeTriangleEnd.setAttribute('fill', gt.color.underConstructionFixed);
if (this.hlObjs.hl_arrow)
this.hlObjs.hl_arrow.rendNodeTriangleEnd.style.fill = gt.color.underConstructionFixed;
}

if (this.hlObjs.hl_segment) {
Expand Down Expand Up @@ -901,10 +904,7 @@
aria: { enabled: true, hidden: true, live: 'off' }
}
);
this.hlObjs.hl_arrow.rendNodeTriangleEnd.setAttribute(
'fill',
gt.color.underConstruction
);
this.hlObjs.hl_arrow.rendNodeTriangleEnd.style.fill = gt.color.underConstruction;

if (gt.options.useBracketEnds) this.hlObjs.hl_text.setAttribute({ strokeOpacity: 0 });
else this.hlObjs.hl_point.setAttribute({ strokeOpacity: 0, fillOpacity: 0 });
Expand Down