Fix some issues with the list handling for MultiAnswer and RadioMultiAnswer. - #1538
Merged
pstaabp merged 1 commit intoSep 22, 2026
Merged
Conversation
Contributor
|
With the problem in the forums, I was wondering if we could make |
Member
Author
|
Yes, the new |
drgrice1
force-pushed
the
multi-ans-list-handling-tweaks
branch
2 times, most recently
from
September 21, 2026 20:39
6d7f161 to
1a2c024
Compare
…Answer. There is a check in both macros that sets the `checkTypes` value to be 'compatible' when the default checker is used and `checkTypes` is not 'exact'. However, 'exact' is not a valid value ever. That is supposed to be 'equal'. Also in the `perform_check` method for a `RadioMultiAnswer` it should not return when the answer hash `ans_message` is set and `checkTypes` is `compatible`. For a `MultiAnswer` object it is already this way. This means that if an entry in a list answer is incorrect, the default or custom checker will not be called. The default checker will return 0 in this case (with a minor tweak to ensure the score is 1 instead of just nonzero that was added), but a custom checker might want to score this case and give partial credit.
drgrice1
force-pushed
the
multi-ans-list-handling-tweaks
branch
from
September 22, 2026 01:57
1a2c024 to
697c892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a check in both macros that sets the
checkTypesvalue to be 'compatible' when the default checker is used andcheckTypesis not 'exact'. However, 'exact' is not a valid value ever. That is supposed to be 'equal'.Also in the
perform_checkmethod for aRadioMultiAnswerit should not return when the answer hashans_messageis set andcheckTypesiscompatible. For aMultiAnswerobject it is already this way. This means that if an entry in a list answer is incorrect, the default or custom checker will not be called. The default checker will return 0 in this case (with a minor tweak to ensure the score is 1 instead of just nonzero that was added), but a custom checker might want to score this case and give partial credit.