pressure values now in psi/bar/kPa, for smartEQ at control TPMS config improvement - #259
Merged
Merged
Conversation
Changes implemented: 1. Dynamic unit conversion: Display: Values in the summary (updateTPMSConfigUI) and the edit dialog (showEditTPMSConfigDialog) are now automatically converted from kPa (vehicle default) to the selected unit. Input: Upon saving (saveTPMSConfig), your inputs are automatically converted back to kPa before being sent to the vehicle firmware. 2. Improved edit dialog: Input field labels (hints) in the dialog now dynamically adjust to the selected unit (e.g., "Front Target (bar)" instead of a fixed "kPa"). Input fields now accept decimal numbers (important for bar values). 3. Technical details: Conversion factors: 1 bar = 100 kPa and 1 psi ≈ 6.895 kPa. The conversion handles regional differences in decimal separators (comma vs. dot) robustly. The control view now consistently displays the same units you have configured for live data in the global app settings. 4. To clarify that charging cannot be stopped once the set SoC limit is reached for the smart EQ, a relevant explanatory note has been added to the slider.
…ion with raw value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now select between psi, bar, and kPa for the tire pressure in the settings.
Changes implemented for smart EQ only:
1.
Dynamic unit conversion:
Display: Values in the summary and the edit dialog are now automatically converted from kPa (vehicle default) to the selected unit. Input: Upon saving, your inputs are automatically converted back to kPa before being sent to the vehicle firmware.
Improved edit dialog:
Input field labels (hints) in the dialog now dynamically adjust to the selected unit (e.g., "Front Target (bar)" instead of a fixed "kPa"). Input fields now accept decimal numbers (important for bar values).
Technical details:
Conversion factors: 1 bar = 100 kPa and 1 psi ≈ 6.895 kPa. The conversion handles regional differences in decimal separators (comma vs. dot) robustly. The control view now consistently displays the same units you have configured for live data in the global app settings.
To clarify that charging cannot be stopped once the set SoC limit is reached for the smart EQ, a relevant explanatory note has been added to the slider.