Skip to content

Commit ee43f65

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Use class FakeServer in TestServerResize."
2 parents 1346ae5 + c904162 commit ee43f65

1 file changed

Lines changed: 18 additions & 21 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -617,13 +617,10 @@ class TestServerResize(TestServer):
617617
def setUp(self):
618618
super(TestServerResize, self).setUp()
619619

620+
self.server = fakes.FakeServer.create_one_server()
621+
620622
# This is the return value for utils.find_resource()
621-
self.servers_get_return_value = fakes.FakeResource(
622-
None,
623-
copy.deepcopy(compute_fakes.SERVER),
624-
loaded=True,
625-
)
626-
self.servers_mock.get.return_value = self.servers_get_return_value
623+
self.servers_mock.get.return_value = self.server
627624

628625
self.servers_mock.resize.return_value = None
629626
self.servers_mock.confirm_resize.return_value = None
@@ -642,20 +639,20 @@ def setUp(self):
642639

643640
def test_server_resize_no_options(self):
644641
arglist = [
645-
compute_fakes.server_id,
642+
self.server.id,
646643
]
647644
verifylist = [
648645
('confirm', False),
649646
('revert', False),
650-
('server', compute_fakes.server_id),
647+
('server', self.server.id),
651648
]
652649
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
653650

654651
# DisplayCommandBase.take_action() returns two tuples
655652
self.cmd.take_action(parsed_args)
656653

657654
self.servers_mock.get.assert_called_with(
658-
compute_fakes.server_id,
655+
self.server.id,
659656
)
660657

661658
self.assertNotCalled(self.servers_mock.resize)
@@ -665,28 +662,28 @@ def test_server_resize_no_options(self):
665662
def test_server_resize(self):
666663
arglist = [
667664
'--flavor', compute_fakes.flavor_id,
668-
compute_fakes.server_id,
665+
self.server.id,
669666
]
670667
verifylist = [
671668
('flavor', compute_fakes.flavor_id),
672669
('confirm', False),
673670
('revert', False),
674-
('server', compute_fakes.server_id),
671+
('server', self.server.id),
675672
]
676673
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
677674

678675
# DisplayCommandBase.take_action() returns two tuples
679676
self.cmd.take_action(parsed_args)
680677

681678
self.servers_mock.get.assert_called_with(
682-
compute_fakes.server_id,
679+
self.server.id,
683680
)
684681
self.flavors_mock.get.assert_called_with(
685682
compute_fakes.flavor_id,
686683
)
687684

688685
self.servers_mock.resize.assert_called_with(
689-
self.servers_get_return_value,
686+
self.server,
690687
self.flavors_get_return_value,
691688
)
692689
self.assertNotCalled(self.servers_mock.confirm_resize)
@@ -695,51 +692,51 @@ def test_server_resize(self):
695692
def test_server_resize_confirm(self):
696693
arglist = [
697694
'--confirm',
698-
compute_fakes.server_id,
695+
self.server.id,
699696
]
700697
verifylist = [
701698
('confirm', True),
702699
('revert', False),
703-
('server', compute_fakes.server_id),
700+
('server', self.server.id),
704701
]
705702
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
706703

707704
# DisplayCommandBase.take_action() returns two tuples
708705
self.cmd.take_action(parsed_args)
709706

710707
self.servers_mock.get.assert_called_with(
711-
compute_fakes.server_id,
708+
self.server.id,
712709
)
713710

714711
self.assertNotCalled(self.servers_mock.resize)
715712
self.servers_mock.confirm_resize.assert_called_with(
716-
self.servers_get_return_value,
713+
self.server,
717714
)
718715
self.assertNotCalled(self.servers_mock.revert_resize)
719716

720717
def test_server_resize_revert(self):
721718
arglist = [
722719
'--revert',
723-
compute_fakes.server_id,
720+
self.server.id,
724721
]
725722
verifylist = [
726723
('confirm', False),
727724
('revert', True),
728-
('server', compute_fakes.server_id),
725+
('server', self.server.id),
729726
]
730727
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
731728

732729
# DisplayCommandBase.take_action() returns two tuples
733730
self.cmd.take_action(parsed_args)
734731

735732
self.servers_mock.get.assert_called_with(
736-
compute_fakes.server_id,
733+
self.server.id,
737734
)
738735

739736
self.assertNotCalled(self.servers_mock.resize)
740737
self.assertNotCalled(self.servers_mock.confirm_resize)
741738
self.servers_mock.revert_resize.assert_called_with(
742-
self.servers_get_return_value,
739+
self.server,
743740
)
744741

745742

0 commit comments

Comments
 (0)