Skip to content

Commit 1346ae5

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Use class FakeServer in TestServerImageCreate."
2 parents 27f1876 + 588d734 commit 1346ae5

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -476,12 +476,10 @@ class TestServerImageCreate(TestServer):
476476
def setUp(self):
477477
super(TestServerImageCreate, self).setUp()
478478

479+
self.server = fakes.FakeServer.create_one_server()
480+
479481
# This is the return value for utils.find_resource()
480-
self.servers_mock.get.return_value = fakes.FakeResource(
481-
None,
482-
copy.deepcopy(compute_fakes.SERVER),
483-
loaded=True,
484-
)
482+
self.servers_mock.get.return_value = self.server
485483

486484
self.servers_mock.create_image.return_value = image_fakes.image_id
487485

@@ -496,10 +494,10 @@ def setUp(self):
496494

497495
def test_server_image_create_no_options(self):
498496
arglist = [
499-
compute_fakes.server_id,
497+
self.server.id,
500498
]
501499
verifylist = [
502-
('server', compute_fakes.server_id),
500+
('server', self.server.id),
503501
]
504502
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
505503

@@ -509,7 +507,7 @@ def test_server_image_create_no_options(self):
509507
# ServerManager.create_image(server, image_name, metadata=)
510508
self.servers_mock.create_image.assert_called_with(
511509
self.servers_mock.get.return_value,
512-
compute_fakes.server_name,
510+
self.server.name,
513511
)
514512

515513
collist = ('id', 'name', 'owner', 'protected', 'tags', 'visibility')
@@ -527,11 +525,11 @@ def test_server_image_create_no_options(self):
527525
def test_server_image_create_name(self):
528526
arglist = [
529527
'--name', 'img-nam',
530-
compute_fakes.server_id,
528+
self.server.id,
531529
]
532530
verifylist = [
533531
('name', 'img-nam'),
534-
('server', compute_fakes.server_id),
532+
('server', self.server.id),
535533
]
536534
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
537535

0 commit comments

Comments
 (0)