Skip to content

Commit 27f1876

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Use class FakeServer in TestServerDelete."
2 parents 1f2fcb5 + 1cf5c55 commit 27f1876

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -398,76 +398,75 @@ class TestServerDelete(TestServer):
398398
def setUp(self):
399399
super(TestServerDelete, self).setUp()
400400

401+
self.server = fakes.FakeServer.create_one_server()
402+
401403
# This is the return value for utils.find_resource()
402-
self.servers_mock.get.return_value = fakes.FakeResource(
403-
None,
404-
copy.deepcopy(compute_fakes.SERVER),
405-
loaded=True,
406-
)
404+
self.servers_mock.get.return_value = self.server
405+
407406
self.servers_mock.delete.return_value = None
408407

409408
# Get the command object to test
410409
self.cmd = server.DeleteServer(self.app, None)
411410

412411
def test_server_delete_no_options(self):
413412
arglist = [
414-
compute_fakes.server_id,
413+
self.server.id,
415414
]
416415
verifylist = [
417-
('server', [compute_fakes.server_id]),
416+
('server', [self.server.id]),
418417
]
419418
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
420419

421420
# DisplayCommandBase.take_action() returns two tuples
422421
self.cmd.take_action(parsed_args)
423422

424423
self.servers_mock.delete.assert_called_with(
425-
compute_fakes.server_id,
424+
self.server.id,
426425
)
427426

428427
@mock.patch.object(common_utils, 'wait_for_delete', return_value=True)
429428
def test_server_delete_wait_ok(self, mock_wait_for_delete):
430429
arglist = [
431-
compute_fakes.server_id, '--wait'
430+
self.server.id, '--wait'
432431
]
433432
verifylist = [
434-
('server', [compute_fakes.server_id]),
433+
('server', [self.server.id]),
435434
]
436435
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
437436

438437
# DisplayCommandBase.take_action() returns two tuples
439438
self.cmd.take_action(parsed_args)
440439

441440
self.servers_mock.delete.assert_called_with(
442-
compute_fakes.server_id,
441+
self.server.id,
443442
)
444443

445444
mock_wait_for_delete.assert_called_once_with(
446445
self.servers_mock,
447-
compute_fakes.server_id,
446+
self.server.id,
448447
callback=server._show_progress
449448
)
450449

451450
@mock.patch.object(common_utils, 'wait_for_delete', return_value=False)
452451
def test_server_delete_wait_fails(self, mock_wait_for_delete):
453452
arglist = [
454-
compute_fakes.server_id, '--wait'
453+
self.server.id, '--wait'
455454
]
456455
verifylist = [
457-
('server', [compute_fakes.server_id]),
456+
('server', [self.server.id]),
458457
]
459458
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
460459

461460
# DisplayCommandBase.take_action() returns two tuples
462461
self.assertRaises(SystemExit, self.cmd.take_action, parsed_args)
463462

464463
self.servers_mock.delete.assert_called_with(
465-
compute_fakes.server_id,
464+
self.server.id,
466465
)
467466

468467
mock_wait_for_delete.assert_called_once_with(
469468
self.servers_mock,
470-
compute_fakes.server_id,
469+
self.server.id,
471470
callback=server._show_progress
472471
)
473472

0 commit comments

Comments
 (0)