Use class FakeServer in TestServerDelete.

There are the same problems with TestServerCreate in TestServerDelete.
Use the new class FakeServer to fix them.

Change-Id: Icdcc90cc93ed1080187fb0edca885b0db56ab35d
Implements: blueprint osc-unit-test-framework-improvement

Author: tang-chen

openstackclient/tests/compute/v2/test_server.py

@@ -398,76 +398,75 @@ class TestServerDelete(TestServer):
     def setUp(self):
         super(TestServerDelete, self).setUp()
 
+        self.server = fakes.FakeServer.create_one_server()
+
         # This is the return value for utils.find_resource()
-        self.servers_mock.get.return_value = fakes.FakeResource(
-            None,
-            copy.deepcopy(compute_fakes.SERVER),
-            loaded=True,
-        )
+        self.servers_mock.get.return_value = self.server
+
         self.servers_mock.delete.return_value = None
 
         # Get the command object to test
         self.cmd = server.DeleteServer(self.app, None)
 
     def test_server_delete_no_options(self):
         arglist = [
-            compute_fakes.server_id,
+            self.server.id,
         ]
         verifylist = [
-            ('server', [compute_fakes.server_id]),
+            ('server', [self.server.id]),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         # DisplayCommandBase.take_action() returns two tuples
         self.cmd.take_action(parsed_args)
 
         self.servers_mock.delete.assert_called_with(
-            compute_fakes.server_id,
+            self.server.id,
         )
 
     @mock.patch.object(common_utils, 'wait_for_delete', return_value=True)
     def test_server_delete_wait_ok(self, mock_wait_for_delete):
         arglist = [
-            compute_fakes.server_id, '--wait'
+            self.server.id, '--wait'
         ]
         verifylist = [
-            ('server', [compute_fakes.server_id]),
+            ('server', [self.server.id]),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         # DisplayCommandBase.take_action() returns two tuples
         self.cmd.take_action(parsed_args)
 
         self.servers_mock.delete.assert_called_with(
-            compute_fakes.server_id,
+            self.server.id,
         )
 
         mock_wait_for_delete.assert_called_once_with(
             self.servers_mock,
-            compute_fakes.server_id,
+            self.server.id,
             callback=server._show_progress
         )
 
     @mock.patch.object(common_utils, 'wait_for_delete', return_value=False)
     def test_server_delete_wait_fails(self, mock_wait_for_delete):
         arglist = [
-            compute_fakes.server_id, '--wait'
+            self.server.id, '--wait'
         ]
         verifylist = [
-            ('server', [compute_fakes.server_id]),
+            ('server', [self.server.id]),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         # DisplayCommandBase.take_action() returns two tuples
         self.assertRaises(SystemExit, self.cmd.take_action, parsed_args)
 
         self.servers_mock.delete.assert_called_with(
-            compute_fakes.server_id,
+            self.server.id,
         )
 
         mock_wait_for_delete.assert_called_once_with(
             self.servers_mock,
-            compute_fakes.server_id,
+            self.server.id,
             callback=server._show_progress
         )