Set Priviledged default to false in workflow - #509
Conversation
The Priviledged parameter should be set to false as a default. It is done like that for the common option in spec already, but not in the workflow variant. This PR sets the default=false in the workflow section to keep the code consistent.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: Comment |
|
@kstrenkova: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
After more investigation, setting the parameter in workflow is not necessary. It should be inherited as false from the parent spec. |
The Priviledged parameter should be set to false as a default. It is done like that for the common option in spec already, but not in the workflow variant. This PR sets the default=false in the workflow section to keep the code consistent.