Skip to content

Set Priviledged default to false in workflow - #509

Closed
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:add-default-privilege-false
Closed

Set Priviledged default to false in workflow#509
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:add-default-privilege-false

Conversation

@kstrenkova

Copy link
Copy Markdown
Contributor

The Priviledged parameter should be set to false as a default. It is done like that for the common option in spec already, but not in the workflow variant. This PR sets the default=false in the workflow section to keep the code consistent.

The Priviledged parameter should be set to false as a default. It
is done like that for the common option in spec already, but not
in the workflow variant. This PR sets the default=false in the
workflow section to keep the code consistent.
@openshift-ci
openshift-ci Bot requested review from abays and stuggi September 8, 2026 11:19
@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 95a62887-2907-481a-a877-7205dfa48943


Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

@kstrenkova: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check b6327d6 link true /test precommit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kstrenkova

Copy link
Copy Markdown
Contributor Author

After more investigation, setting the parameter in workflow is not necessary. It should be inherited as false from the parent spec.

@kstrenkova kstrenkova closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant