Skip to content

Revert clc-ui-e2e to 2.17 in 5.1 FIPS config — fix regression from PR #85679 - #85960

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/revert-clc-ui-e2e-to-2.17
Sep 25, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/revert-clc-ui-e2e-to-2.17

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reverts the clc-ui-e2e base image from "2.18" back to "2.17" in the OCP 5.1 FIPS interop-testing ci-operator config. This is a one-line fix for a regression introduced by #85679 (merged Sep 24).

Root Cause

PR #85679 changed base_images.clc-ui-e2e.name from "2.17" to "2.18" in the 5.1 FIPS config only (the non-FIPS config was left at "2.17"). However, ImageStream "2.18" does not exist in the acm-qe namespace on app.ci:

Error from server (NotFound): imagestreams.image.openshift.io "2.18" not found

ImageStream "2.17" exists and has the clc-ui-e2e tag.

As a result, ci-operator fails at image resolution within ~10-12 minutes on every 5.1 FIPS run since the merge. Pre-merge runs lasted 197-344 minutes.

Change

base_images:
  clc-ui-e2e:
-   name: "2.18"
+   name: "2.17"
    namespace: acm-qe
    tag: clc-ui-e2e

Audit of other configs from #85679

All 17 files changed by #85679 were reviewed. Only the 5.1 FIPS config references "2.18" for clc-ui-e2e. The other configs are unaffected:

Config clc-ui-e2e.name Status
5.1 FIPS "2.18" → "2.17" Fixed by this PR
5.1 non-FIPS "2.17" ✅ OK
5.0 FIPS "2.17" ✅ OK
5.0 non-FIPS "2.17" ✅ OK
4.22 "2.17" ✅ OK

The stolostron policy-collection config and the 11 step-registry files changed by #85679 do not reference clc-ui-e2e.

References

Impact

This fix unblocks the OPP 5.1 FIPS interop periodic job (periodic-ci-RedHatQE-interop-testing-master-opp--ocp-5.1-fips-lpMainline-lp-interop), which has been failing on every run since #85679 merged.

Future note

If ACM 2.18 images are eventually needed, the ACM QE team must first create the "2.18" ImageStream in the acm-qe namespace on app.ci. When that happens, both FIPS and non-FIPS configs should be updated together to avoid this asymmetry.


AI-generated. Review for accuracy.

@amp-rh requested via Chai Bot

Summary by CodeRabbit

The OCP 5.1 FIPS interop-testing CI configuration now uses clc-ui-e2e:2.17 instead of 2.18. This restores the image version reported as available in the acm-qe namespace on app.ci and aims to prevent image-resolution failures in the periodic job.

PR openshift#85679 changed clc-ui-e2e.name from "2.17" to "2.18" in the
5.1 FIPS interop-testing config, but ImageStream "2.18" does not
exist in the acm-qe namespace on app.ci. This causes ci-operator
to fail at image resolution within 10-12 minutes on every 5.1
FIPS run.

Revert to "2.17" which exists and has the clc-ui-e2e tag.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3a9e92b3-696f-417f-aaa6-97d39f9ffd76

📥 Commits

Reviewing files that changed from the base of the PR and between 17598fc and 5de6e35.

📒 Files selected for processing (1)
  • ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__opp--ocp-5.1-fips-lpMainline-lp-interop.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The interop testing configuration changes the clc-ui-e2e base image version from 2.18 to 2.17.

Changes

Interop test image configuration

Layer / File(s) Summary
Update the base image version
ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__opp--ocp-5.1-fips-lpMainline-lp-interop.yaml
The configuration changes the clc-ui-e2e base image version from 2.18 to 2.17.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5de6e

The configuration uses the image version reported as available in acm-qe, and no merge-blocking issue is identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: reverting clc-ui-e2e to version 2.17 in the 5.1 FIPS configuration. It also states the reason for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only one ci-operator YAML value, from clc-ui-e2e image 2.18 to 2.17. It adds or changes no Ginkgo test titles or test code, so the stable and deterministic test-na…
Test Structure And Quality ✅ Passed PASS. The pull request changes one YAML configuration value only: clc-ui-e2e.name changes from "2.18" to "2.17". It adds no Ginkgo tests or cluster operations, so the test-structure requirements…
Microshift Test Compatibility ✅ Passed The pull request changes only one CI configuration value: clc-ui-e2e changes from image 2.18 to 2.17. The authoritative diff adds no Ginkgo tests or test code, so the MicroShift compatibility ch…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only one YAML image reference, from clc-ui-e2e 2.18 to 2.17. It adds no Ginkgo e2e tests and introduces no SNO or multi-node compatibility assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only one ci-operator image reference, from 2.18 to 2.17. It does not add or modify deployment manifests, operator code, controllers, replicas, affinity, topology spr…
Ote Binary Stdout Contract ✅ Passed PASS — The pull request changes only one YAML value: clc-ui-e2e.name from "2.18" to "2.17". It adds no OTE binary code, process-level setup, logging, or stdout write. The stdout contract is ther…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only one YAML image reference, from 2.18 to 2.17, in an internal acm-qe image stream. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requi…
No-Weak-Crypto ✅ Passed PASS: The PR changes only the YAML image name from 2.18 to 2.17. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison logic.
Container-Privileges ✅ Passed The PR changes only the clc-ui-e2e image name from 2.18 to 2.17. It does not add or change privileged, host namespace settings, SYS_ADMIN, allowPrivilegeEscalation, or root execution setti…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only the clc-ui-e2e image name from 2.18 to 2.17 in one YAML configuration. It adds no logging, output statements, credentials, tokens, or personal data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from amp-rh and sg-rh September 25, 2026 14:26
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-RedHatQE-interop-testing-master-opp--ocp-5.1-fips-lpMainline-lp-interop-images RedHatQE/interop-testing presubmit Ci-operator config changed
periodic-ci-RedHatQE-interop-testing-master-opp--ocp-5.1-fips-lpMainline-lp-interop-interop-opp-aws N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@amp-rh

amp-rh commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

/assign

@amp-rh

amp-rh commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 25, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2026
@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amp-rh, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026
@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 459823d into openshift:main Sep 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants