Skip to content

Fix NODEPOOL_N4_VERSION for hypershift release-5.0 e2e-aws-4-22 - #85533

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/nodepool-n4-version-5.0
Sep 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:fix/nodepool-n4-version-5.0

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Problem

The e2e-aws-4-22 job in the HyperShift release-5.0 CI config has NODEPOOL_N4_VERSION set to "4.19", but OCP_IMAGE_N4 points to release:latest-418 (a 4.18 release image). This mismatch causes TestNodePoolPrevReleaseN4 to always fail:

  • The NodePool is tagged as version 4.19
  • A 4.22 HostedCluster supports N-3 (down to 4.19)
  • So SupportedVersionSkew stays True, but the test expects False

The e2e-aks-4-22 variant in the same file already has the correct value "4.18".

This is blocking multiple PRs on the release-5.0 branch, including openshift/hypershift#9598.

Fix

Change NODEPOOL_N4_VERSION from "4.19" to "4.18" in the e2e-aws-4-22 test definition.

Related


AI-generated. Review for accuracy.

@cblecker requested in Slack thread

Summary by CodeRabbit

  • Updated NODEPOOL_N4_VERSION from "4.19" to "4.18" in the HyperShift release-5.0 e2e-aws-4-22 CI test configuration.
  • Aligns the node pool version with the configured OCP_IMAGE_N4 release image and prevents the N-3 version-skew test from producing an unexpected supported result.

The e2e-aws-4-22 job has NODEPOOL_N4_VERSION set to "4.19" but
OCP_IMAGE_N4 points to release:latest-418 (a 4.18 image). This
mismatch causes TestNodePoolPrevReleaseN4 to always fail because
4.19 is within the N-3 supported skew window of a 4.22
HostedCluster, so SupportedVersionSkew stays True when the test
expects False. The e2e-aks-4-22 variant already has the correct
value "4.18".
@openshift-ci
openshift-ci Bot requested review from jparrill and rutvik23 September 19, 2026 21:49
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 8e1d0b37-e86b-49c4-9986-b16c7843df2f

📥 Commits

Reviewing files that changed from the base of the PR and between 38aab9f and cef9936.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__4-23.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The e2e-aws-4-22 test configuration changes NODEPOOL_N4_VERSION from 4.19 to 4.18.

Changes

Hypershift E2E configuration

Layer / File(s) Summary
NodePool version update
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__4-23.yaml
The e2e-aws-4-22 test environment sets NODEPOOL_N4_VERSION to 4.18 instead of 4.19.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: mgencur

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to NODEPOOL_N4_VERSION in the HyperShift release-5.0 e2e-aws-4-22 configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes one YAML configuration value only: NODEPOOL_N4_VERSION from "4.19" to "4.18". It does not change Ginkgo test titles or test code. The changed value is static and deterministic…
Test Structure And Quality ✅ Passed PASS: The pull request changes only one CI YAML value: NODEPOOL_N4_VERSION changes from "4.19" to "4.18" for e2e-aws-4-22. It adds or modifies no Ginkgo test code, resource setup, waits, or as…
Microshift Test Compatibility ✅ Passed The pull request changes only one CI YAML value: NODEPOOL_N4_VERSION changes from "4.19" to "4.18" in an existing e2e-aws-4-22 test step. No Ginkgo test declarations or test code were added, s…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one YAML CI configuration file. The one-line change updates NODEPOOL_N4_VERSION for the existing e2e-aws-4-22 job from "4.19" to "4.18". It adds no Ginkgo tests o…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes one CI environment value in a YAML test definition: NODEPOOL_N4_VERSION changes from "4.19" to "4.18". It does not add or modify deployment manifests, operator cod…
Ote Binary Stdout Contract ✅ Passed The pull request changes only one YAML value: NODEPOOL_N4_VERSION changes from "4.19" to "4.18" in the e2e-aws-4-22 test configuration. It changes no OTE binary, Go source, suite setup, initia…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only one CI YAML value: NODEPOOL_N4_VERSION from "4.19" to "4.18". It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The pull request changes one YAML value: NODEPOOL_N4_VERSION from "4.19" to "4.18". The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparison lo…
Container-Privileges ✅ Passed PASS. The authoritative pull-request diff changes only NODEPOOL_N4_VERSION from "4.19" to "4.18" in one CI YAML test definition. The added line does not introduce privileged: true, hostPID, …
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only one CI environment value: NODEPOOL_N4_VERSION changes from "4.19" to "4.18" in a YAML test definition. The changed file contains no added logging statements or sens…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-release-5.0-4-23-e2e-aws-4-22 openshift/hypershift presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cblecker

Copy link
Copy Markdown
Member

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cblecker

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 20, 2026
@openshift-ci

openshift-ci Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdminonne

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2026
@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, redhat-chai-bot, sdminonne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit acf0092 into openshift:main Sep 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants