Fix NODEPOOL_N4_VERSION for hypershift release-5.0 e2e-aws-4-22 - #85533
openshift-merge-bot[bot] merged 1 commit into
Conversation
The e2e-aws-4-22 job has NODEPOOL_N4_VERSION set to "4.19" but OCP_IMAGE_N4 points to release:latest-418 (a 4.18 image). This mismatch causes TestNodePoolPrevReleaseN4 to always fail because 4.19 is within the N-3 supported skew window of a 4.22 HostedCluster, so SupportedVersionSkew stays True when the test expects False. The e2e-aks-4-22 variant already has the correct value "4.18".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe ChangesHypershift E2E configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse auto-ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, redhat-chai-bot, sdminonne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
The
e2e-aws-4-22job in the HyperShiftrelease-5.0CI config hasNODEPOOL_N4_VERSIONset to"4.19", butOCP_IMAGE_N4points torelease:latest-418(a 4.18 release image). This mismatch causesTestNodePoolPrevReleaseN4to always fail:SupportedVersionSkewstaysTrue, but the test expectsFalseThe
e2e-aks-4-22variant in the same file already has the correct value"4.18".This is blocking multiple PRs on the
release-5.0branch, including openshift/hypershift#9598.Fix
Change
NODEPOOL_N4_VERSIONfrom"4.19"to"4.18"in thee2e-aws-4-22test definition.Related
AI-generated. Review for accuracy.
@cblecker requested in Slack thread
Summary by CodeRabbit
NODEPOOL_N4_VERSIONfrom"4.19"to"4.18"in the HyperShiftrelease-5.0e2e-aws-4-22CI test configuration.OCP_IMAGE_N4release image and prevents the N-3 version-skew test from producing an unexpected supported result.