Skip to content

Only ping chai-bot on rosa-prow-info failures; chai-bot escalates to rosa-ci-watcher - #85531

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:rosa-ci-watcher-dedup
Sep 20, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:rosa-ci-watcher-dedup

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Stop pinging the rosa-ci-watcher Slack subteam on every Prow failure in the ROSA CI notification channel. Only the bot should be pinged by Prow; it will escalate to rosa-ci-watcher in-thread only when a failure genuinely needs human input.

Tracked in ROSAENG-67393.

Changes

Two files, failure-branch report_template only — drop the subteam mention, keep the bot mention:

  • core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml

The report_template failure branch previously pinged both the rosa-ci-watcher subteam and the bot. This PR removes the subteam ping so only the bot is notified by Prow.

Why

Today every red periodic job pings the entire rosa-ci-watcher subteam. With the reactive triage workflow (ROSAENG-67393), the bot triages each failure and only escalates to rosa-ci-watcher when it cannot self-resolve (unowned failures, multi-day blockers, multi-job issues needing human judgement).

Net effect: rosa-ci-watcher goes from "notified on all N failures" to "notified only on the ones the bot can't self-resolve."

Notes

These are Prow config files (core-services/prow/02_config/), not ci-operator config — no make jobs regeneration needed.


AI-generated. Review for accuracy.

@dustman9000 requested via Chai Bot

Summary by CodeRabbit

  • Updated ROSA E2E and ROSA gap-analysis Prow failure notifications.
  • Removed the rosa-ci-watcher subteam mention.
  • Kept the chai-bot mention for failure handling and escalation.

chai-bot is the only thing Prow should ping on failures.
chai-bot will escalate to rosa-ci-watcher in-thread when needed.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 6790c868-ee09-45fc-8d23-2de53cfc4f98

📥 Commits

Reviewing files that changed from the base of the PR and between 38aab9f and ca91b7b.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The two Prow Slack report templates remove the S0B7Q6G7XQR subteam mention. Both templates retain the direct U0AKNPBBVT7 user mention.

Changes

Slack report templates

Layer / File(s) Summary
Remove obsolete subteam mentions
core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml, core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml
The non-success Slack messages no longer mention the S0B7Q6G7XQR subteam. The U0AKNPBBVT7 user mention remains.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the notification change: Prow pings only chai-bot, which can escalate failures to rosa-ci-watcher.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only two Prow YAML notification templates. The diff removes a Slack subteam mention and retains the bot mention. It introduces no Ginkgo tests or test titles, so the sta…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two _prowconfig.yaml files. The patch updates Slack report_template text by removing <!subteam^S0B7Q6G7XQR> and retaining <@U0AKNPBBVT7>. It adds or changes…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only two YAML Prow notification templates. The authoritative diff contains no new Ginkgo tests or test constructs such as It, Describe, Context, or When. Therefore, the …
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only two Prow YAML notification templates. The diff adds no Ginkgo tests or test constructs such as It(), Describe(), Context(), or When(). Therefore, the SNO test compatibili…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only two Prow Slack report templates. It removes a Slack subteam mention and retains the bot mention. The diff adds or modifies no deployment manifest, operator code, co…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only two YAML Prow notification templates. The diff removes a Slack subteam mention and retains the bot mention. It adds no Go or OTE binary process code, suite setup, l…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The authoritative diff changes only two YAML Prow configuration files. It removes a Slack subteam mention from each failure report template and retains the bot mention. No Ginkgo tests, IPv4 net…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only two Prow Slack report templates. Each change removes a Slack subteam mention and retains the bot mention. The diff introduces no cryptographic algorithm, cipher mod…
Container-Privileges ✅ Passed PASS. The pull request changes only two Prow Slack report templates. The diff removes a Slack subteam mention and retains the bot mention. Neither changed YAML file contains privileged, hostPID, `…
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only two Prow Slack report templates. Each change removes the existing rosa-ci-watcher subteam mention and retains the existing bot mention and log URL template. The added lines introdu…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 19, 2026
@openshift-ci

openshift-ci Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2026
@openshift-ci

openshift-ci Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit d24f579 into openshift:main Sep 20, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-online-rosa-e2e-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-online-rosa-gap-analysis-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-online-rosa-e2e-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-online-rosa-gap-analysis-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml
Details

In response to this:

Summary

Stop pinging the rosa-ci-watcher Slack subteam on every Prow failure in the ROSA CI notification channel. Only the bot should be pinged by Prow; it will escalate to rosa-ci-watcher in-thread only when a failure genuinely needs human input.

Tracked in ROSAENG-67393.

Changes

Two files, failure-branch report_template only — drop the subteam mention, keep the bot mention:

  • core-services/prow/02_config/openshift-online/rosa-e2e/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/rosa-gap-analysis/_prowconfig.yaml

The report_template failure branch previously pinged both the rosa-ci-watcher subteam and the bot. This PR removes the subteam ping so only the bot is notified by Prow.

Why

Today every red periodic job pings the entire rosa-ci-watcher subteam. With the reactive triage workflow (ROSAENG-67393), the bot triages each failure and only escalates to rosa-ci-watcher when it cannot self-resolve (unowned failures, multi-day blockers, multi-job issues needing human judgement).

Net effect: rosa-ci-watcher goes from "notified on all N failures" to "notified only on the ones the bot can't self-resolve."

Notes

These are Prow config files (core-services/prow/02_config/), not ci-operator config — no make jobs regeneration needed.


AI-generated. Review for accuracy.

@dustman9000 requested via Chai Bot

Summary by CodeRabbit

  • Updated ROSA E2E and ROSA gap-analysis Prow failure notifications.
  • Removed the rosa-ci-watcher subteam mention.
  • Kept the chai-bot mention for failure handling and escalation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants