multi vcenter mao serial job

[jcpowermac]

Summary by CodeRabbit

• Updates the Machine API Operator CI configuration for multi-vCenter vSphere OVN testing.
• Limits multi-vCenter tests to three vCenters with MAX_VCENTERS: "3".
• Skips in-tree vSphere volume tests in the non-serial multi-vCenter job.
• Adds an optional multi-vCenter serial conformance job with a six-hour timeout.

[coderabbitai]

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c6a1f64d-786d-429c-be1b-3f13a1fd7c9d

📥 Commits

Reviewing files that changed from the base of the PR and between 38aab9f and dcdc44d.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The machine API operator test configuration now limits multi-vCenter OVN tests to three vCenters and adds an optional serial conformance variant. In-tree vSphere volume tests remain skipped.

Changes

Multi-vCenter Test Configuration

Layer / File(s)	Summary
Multi-vCenter test variants ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-main.yaml	The existing test uses MAX_VCENTERS: "3" instead of a fixed pool list. An optional variant runs openshift/conformance/serial with the same limit. The volume skip rule remains.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: psalajova

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the main change: adding a multi-vCenter MAO serial job. It is concise and related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only CI configuration and generated Prow job metadata. It adds static job and workflow names, MAX_VCENTERS: "3", and TEST_SUITE: openshift/conformance/serial. No Ginkgo te…
Test Structure And Quality	✅ Passed	PASS. The authoritative diff changes only two YAML CI configuration files. It adds and updates vSphere job declarations and generated presubmit metadata. It does not change Ginkgo source, It blocks,…
Microshift Test Compatibility	✅ Passed	The pull request changes only CI YAML. It updates vSphere environment variables and adds a presubmit job that runs the existing serial conformance suite. It does not add or modify Ginkgo test declarat…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only two YAML configuration files. The exact diff adds a CI job and environment settings for the existing openshift-e2e-test workflow; it adds no Ginkgo test declarations or…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only CI operator configuration and generated Prow presubmit configuration. The diff adds or changes vSphere test environment variables, test-suite selection, timeout, an…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only two declarative YAML files. The config change sets MAX_VCENTERS, TEST_SKIPS, and TEST_SUITE, and adds a workflow target. The generated presubmit change adds C…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only CI YAML. The authoritative diff adds no Ginkgo test code and no hardcoded IPv4 address, IPv4 CIDR, URL, or external connectivity command. The new serial job invokes the existing `o…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only CI YAML configuration. It adds a multi-vCenter serial test job, changes the vCenter limit variable, and adds generated Kubernetes job configuration. The diff introd…
Container-Privileges	✅ Passed	The pull request does not introduce any prohibited container privilege setting. The changed CI configuration adds MAX_VCENTERS, TEST_SUITE, and a serial vSphere test. The generated presubmit adds …
No-Sensitive-Data-In-Logs	✅ Passed	The pull request does not add logging commands or log statements. It adds fixed test controls (MAX_VCENTERS: "3" and TEST_SUITE) and a generated presubmit job. The new job only references existing…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[jcpowermac]

related: openshift/machine-api-operator#1552

[jcpowermac]

/assign @vr4manta

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-api-operator/OWNERS
• ci-operator/jobs/openshift/machine-api-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

/pj-rehearse pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-multi-vcenter-serial

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-multi-vcenter-serial	openshift/machine-api-operator	presubmit	Presubmit changed
pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-multi-vcenter	openshift/machine-api-operator	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jcpowermac]

/pj-rehearse pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-multi-vcenter-serial

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.