Skip to content

setup assisted-installer version v2.55 - #84756

Closed
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-ef8af1bd-38ae-444c-98af-c3bdb40a5867
Closed

danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-ef8af1bd-38ae-444c-98af-c3bdb40a5867

Conversation

@danmanor

@danmanor danmanor commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates Assisted Installer, Installer Agent, and Image Service CI configurations to use backplane-5.1 test infrastructure images.
  • Adjusts metal end-to-end test skip rules to apply at the pipeline level and disables automatic execution where configured.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d15dbcf7-1914-4415-8103-fb99835f86f7

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb5e61 and 2ee94d7.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The pull request updates assisted test infrastructure images from backplane-5.0 to backplane-5.1. It also changes selected end-to-end test filters to use pipeline_skip_if_only_changed with always_run: false.

Changes

Assisted test configuration

Layer / File(s) Summary
Update assisted test infrastructure images
ci-operator/config/openshift/assisted-image-service/..., ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The assisted test infrastructure images now use the backplane-5.1 tag.
Adjust end-to-end test execution filters
ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The affected tests now set always_run: false and use pipeline_skip_if_only_changed with the existing path patterns.

Priority: ⬇️ Low — Defer this change because it is a small assisted-installer test-configuration update limited to base-image references and pipeline test filters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2ee94

This updates assisted test infrastructure images to backplane-5.1 and refines when selected end-to-end tests run. The supplied configuration assessment found no current merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: setting up assisted-installer version v2.55. This matches the updated v2.55 configuration files and related test settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS — The diff changes image tags, skip annotations, and static CI test/job identifiers only. It adds no Ginkgo title calls such as It, Describe, Context, or When. The changed identifiers (`s…
Test Structure And Quality ✅ Passed PASS. The pull request changes only three declarative CI YAML files. The changes update image tags and CI filtering fields such as always_run and pipeline_skip_if_only_changed. The target director…
Microshift Test Compatibility ✅ Passed PASS — The pull request adds no Ginkgo tests. The diff contains only YAML configuration and generated presubmit job changes: base image tag updates and skip-filter settings. No new It, Describe, `…
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are introduced. The affected files are YAML CI configurations. Their changes update image tags and CI job filtering metadata. Searches found no Ginkgo declarations or Go test f…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR changes only CI configuration. The diff updates backplane-5.0 image tags and changes Prow test skip metadata (always_run and pipeline_skip_if_only_changed). It adds or modifies no d…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only five YAML configuration files. The diff updates backplane-5.0 to backplane-5.1 and changes CI skip metadata. It adds no OTE binary source, main() or suite set…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No applicable compatibility failure is introduced. The PR changes three CI YAML files, not Ginkgo test source. Comparison with the prior v2.54 configurations shows only version, branch, service-refere…
No-Weak-Crypto ✅ Passed The pull request changes CI YAML configuration only. The inspected v2.55 files update image tags and test-skip settings. A focused scan found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto…
Container-Privileges ✅ Passed No container privilege violation was introduced. The pull request changes only base-image tags, test scheduling filters, and generated annotations. The exact diff adds no privileged, hostPID, `hos…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only CI YAML metadata. The diff updates base-image tags and test skip annotations, and adds always_run: false; it does not add logging commands, log statements, or sen…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-cnv openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-external openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-ipv6 openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-lvm openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-odf openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted-single-node openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-oci-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-e2e-vsphere-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-format-check openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-images openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-lint openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-v2.55-unit-test openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-e2e-metal-assisted openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-e2e-metal-assisted-day2-arm-workers openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-e2e-metal-assisted-deploy-nodes openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-e2e-metal-assisted-external openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-e2e-oci-assisted openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-images openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-lint openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-image-service-v2.55-test openshift/assisted-image-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-cnv openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-day2 openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted-external openshift/assisted-installer-agent presubmit Ci-operator config changed

A total of 35 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor

danmanor commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #84845

@danmanor danmanor closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants