debug-cluster-agent-4.20

[jiezhao16]

Temporary PR to rehearse agent metal3 conformance job with wait step for 4.20 Agent bug verification.

Summary by CodeRabbit

Adds a wait step to the OpenShift 4.20 MCE Agent Metal3 conformance periodic job, enabling rehearsal of the Agent bug verification process.

[coderabbitai]

Walkthrough

The periodic MCE job configuration adds a test stanza containing one entry referencing wait, positioned before the existing workflow field.

Changes

Periodic MCE test configuration

Layer / File(s)	Summary
Add periodic job test entry ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml	Adds a test list with a single ref: wait entry to the existing job configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: redhat-chai-bot

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and does not clearly describe the actual change to the Agent Metal3 conformance job.	Rename it to reflect the main change, such as adding a wait step to the 4.20 Agent Metal3 conformance job.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a YAML periodic job config changed; no Ginkgo It/Describe/Context/When test titles were added or modified.
Test Structure And Quality	✅ Passed	Only a ci-operator periodic YAML changed; no Ginkgo test code or It/BeforeEach/Eventually blocks were added, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only modifies a ci-operator periodic YAML to add a wait ref; no Ginkgo e2e tests or OpenShift API usage were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a CI job config gained a wait step; no new Ginkgo e2e tests or SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a periodic CI YAML gained a test: [ref: wait] step; no manifests, controllers, replicas, affinity, or node selectors were added.
Ote Binary Stdout Contract	✅ Passed	Only a ci-operator YAML periodic job changed; no main/init/TestMain/suite-setup code or stdout writes were modified, so the OTE stdout contract isn't implicated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only adds a ref: wait step in CI YAML; no Ginkgo test code or IP/network logic changed, and the referenced workflow already supports IPv4 and dual-stack.
No-Weak-Crypto	✅ Passed	PASS: The diff only adds test: - ref: wait to a YAML job; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	The change only adds test: - ref: wait; the referenced wait-ref.yaml has no privileged, host*, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only adds a test: - ref: wait stanza; no new logging or sensitive-data fields appear in the changed YAML.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiezhao16
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jiezhao16: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml`:
- Around line 88-89: Regenerate the derived ci-operator/jobs artifacts from the
updated periodic configuration by running make update, then commit the resulting
generated changes alongside the openshift-hypershift-release-4.20__periodics-mce
configuration.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4a1d4d86-2fc5-4bfa-93a4-2c0d84dab7bb

📥 Commits

Reviewing files that changed from the base of the PR and between 0fcdafe and 264bc12.

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

make registry-metadata && make ci-operator-config && make jobs

Repository: openshift/release

Length of output: 197

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Map the target file and inspect its context.
git ls-files 'ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml'
wc -l ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml
sed -n '1,180p' ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml

# Look for generated metadata / job references nearby.
rg -n --hidden --glob '!**/.git/**' 'zz_generated_metadata|make update|make jobs|make ci-operator-config|make registry-metadata' ci-operator/config/openshift/hypershift -S

Repository: openshift/release

Length of output: 11764

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

sed -n '320,377p' ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml

Repository: openshift/release

Length of output: 1975

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

git ls-files 'Makefile' 'makefile' 'GNUmakefile'
if git ls-files 'Makefile' >/dev/null 2>&1; then
  rg -n '^(update|ci-operator-config|jobs|registry-metadata):' Makefile
fi

Repository: openshift/release

Length of output: 270

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find generated job config counterparts and references to this variant.
rg -n --hidden --glob '!**/.git/**' 'periodics-mce|openshift-hypershift-release-4.20__periodics-mce|variant: periodics-mce' ci-operator/jobs ci-operator/config -S

# Show any files under ci-operator/jobs that look related.
fd -t f 'periodics-mce' ci-operator/jobs ci-operator/config

Repository: openshift/release

Length of output: 50373

---

Regenerate generated CI artifacts
This ci-operator/config change needs the generated ci-operator/jobs output refreshed and committed with make update, or the periodic job config will drift.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.20__periodics-mce.yaml`
around lines 88 - 89, Regenerate the derived ci-operator/jobs artifacts from the
updated periodic configuration by running make update, then commit the resulting
generated changes alongside the openshift-hypershift-release-4.20__periodics-mce
configuration.

Sources: Coding guidelines, Learnings

[jiezhao16]

/pj-rehearse periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance

[openshift-merge-bot]

@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jiezhao16: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.