[release-5.0] OCPBUGS-120715: Add Degraded=True exception for authentication operator during upgrade - #31608
Conversation
…or during upgrade The authentication operator transiently goes Degraded for ~8.5 seconds during upgrade rollout when oauth-apiserver and oauth-server pods are briefly unavailable. This is the same pattern already excepted for kube-apiserver (OCPBUGS-38661), kube-controller-manager (OCPBUGS-38662), and kube-scheduler (OCPBUGS-38663). Add a narrow exception scoped to UnavailablePod reasons only, so transient pod rollout states are classified as flakes rather than hard failures. This unblocks the OKD SCOS 5.0 promoted upgrade job which has been failing consistently since ec.4 (OKD-424).
… upgrade Verifies that the authentication operator's transient Degraded=True state during upgrade is correctly excepted for UnavailablePod reasons, while unrelated Degraded reasons remain hard failures.
- Use strings.Contains for reason matching instead of exact matches, preserving the original breadth and avoiding regressions on two-node clusters - Return a descriptive message with bug ID instead of a bare URL - Update tests to match the new strings.Contains behavior
…oNode guard Address review feedback from hongkailiu and Prashanth684: - Restore the original isTwoNode guard for DualReplica clusters - Add separate isOKD guard for OKD SCOS clusters only, keeping OCP HA uncovered so regressions are detected - Return full bug URL for easy copy-paste from job logs - Add isOKDCluster() helper following the existing isVSphere() pattern - Mark the OKD exception as temporary until the auth operator is fixed - Update tests to cover DualReplica and HA non-OKD paths separately
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-111997 has been cloned as Jira Issue OCPBUGS-120715. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-120715, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
/verified |
|
@pskrbasu: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override-sticky ci/prow/e2e-vsphere-ovn-upi Automated triage: This failure appears unrelated to the PR changes. Job classification: Eligible long-running presubmit e2e/integration job: Revision check: Incoming/run SHA Execution status: Tests executed. The pre phase succeeded, the e2e test ran for Completed supporting jobs: Overlap assessment: The PR changes only CVO legacy monitor logic and its unit tests: an OKD authentication-operator Missing-coverage risk: Low. This job executed the conformance suite; the only blocking failure is the isolated CRD validation test. Test history records prior failures for this exact test and no open bug, while this run shows a CRD cleanup timeout coincident with an API-server-down event. Rationale: The failure is a known, previously failing API-server/cleanup test signal and is unrelated to the PR's CVO authentication-monitor changes. The override is therefore appropriate for this completed long-running e2e run. If you disagree with this assessment, rerun the current job with AI-generated. Review for accuracy. |
|
@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-vsphere-ovn-upi These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #31535
/assign pskrbasu