OCPBUGS-86789: Bump network config timeout to 25 minutes

[jacobsee]

This is needed because KAS rollout on AWS now has a 300 sec (x3) rollout delay due to long LB drain times, which pushes the whole process now slightly over 20 min.

Summary by CodeRabbit

• Bug Fixes
  • Increased the wait time for network configuration updates and kube-apiserver rollouts to reduce failures caused by slow operations.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobsee
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 05a80923-9140-4d36-aa08-eea80b519629

📥 Commits

Reviewing files that changed from the base of the PR and between f097372 and 9c30e6f.

📒 Files selected for processing (1)

• test/extended/networking/util.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The network configuration update and kube-apiserver rollout now have a 25-minute timeout instead of 20 minutes.

Changes

Network configuration rollout

Layer / File(s)	Summary
Extend rollout deadline test/extended/networking/util.go	modifyNetworkConfig increases its context timeout from 20 to 25 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9c30e

This localized timeout increase supports longer rollout completion and introduces no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: increasing the network configuration timeout from 20 to 25 minutes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only the timeout in modifyNetworkConfig from 20 to 25 minutes. It adds no Ginkgo test title and introduces no dynamic test-name value. The existing Context titles ar…
Test Structure And Quality	✅ Passed	PASS. The pull request changes only the modifyNetworkConfig context timeout from 20 to 25 minutes. The function already applies this context to network updates and WaitForOperatorToRollout, and th…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only the existing modifyNetworkConfig timeout from 20 to 25 minutes in test/extended/networking/util.go. The committed diff adds no Ginkgo e2e tests or test declarat…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only the timeout in test/extended/networking/util.go from 20 to 25 minutes. The parent-to-HEAD diff adds no Ginkgo e2e tests (It, Describe, Context, or When) a…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only the timeout in test/extended/networking/util.go from 20*time.Minute to 25*time.Minute inside modifyNetworkConfig. The function waits for the kube-apiserver …
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only 20*time.Minute to 25*time.Minute in modifyNetworkConfig. The diff introduces no stdout writes, logging configuration, or process-level setup code. The helper …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The PR changes only the existing modifyNetworkConfig timeout from 20 to 25 minutes in test/extended/networking/util.go. The parent-to-HEAD diff adds no Ginkgo test and no IPv4 or external-c…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only the modifyNetworkConfig context timeout from 20 to 25 minutes. The introduced line contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or s…
Container-Privileges	✅ Passed	PASS. The pull request changes only the timeout in modifyNetworkConfig from 20 to 25 minutes. It does not add or change privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or `allowPrivi…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only the context timeout from 20 to 25 minutes. The changed line adds no logging and does not expose passwords, tokens, API keys, PII, session IDs, hostnames, or custome…

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only the timeout in modifyNetworkConfig from 20 to 25 minutes. It adds no Ginkgo test title and introduces no dynamic test-name value. The existing Context titles are static and unchanged.

Full details: Test Structure And Quality

Explanation

PASS. The pull request changes only the modifyNetworkConfig context timeout from 20 to 25 minutes. The function already applies this context to network updates and WaitForOperatorToRollout, and the rollout helper uses the context to terminate its waits. No It block, setup or cleanup, assertion, or wait structure changed. Therefore, no stated test-structure failure was introduced.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only the existing modifyNetworkConfig timeout from 20 to 25 minutes in test/extended/networking/util.go. The committed diff adds no Ginkgo e2e tests or test declarations, so the MicroShift compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only the timeout in test/extended/networking/util.go from 20 to 25 minutes. The parent-to-HEAD diff adds no Ginkgo e2e tests (It, Describe, Context, or When) and introduces no multi-node or HA assumption. The SNO test compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only the timeout in test/extended/networking/util.go from 20*time.Minute to 25*time.Minute inside modifyNetworkConfig. The function waits for the kube-apiserver rollout and updates network configuration. The diff adds no deployment manifest, operator/controller code, replica setting, affinity, topology spread constraint, node selector, toleration, or PDB. The topology-aware scheduling check is therefore not triggered.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only 20*time.Minute to 25*time.Minute in modifyNetworkConfig. The diff introduces no stdout writes, logging configuration, or process-level setup code. The helper contains no stdout-related operation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The PR changes only the existing modifyNetworkConfig timeout from 20 to 25 minutes in test/extended/networking/util.go. The parent-to-HEAD diff adds no Ginkgo test and no IPv4 or external-connectivity logic. Existing IPv4 CIDRs in unchanged test call sites are pre-existing and do not establish PR causality.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only the modifyNetworkConfig context timeout from 20 to 25 minutes. The introduced line contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret comparison logic.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only the timeout in modifyNetworkConfig from 20 to 25 minutes. It does not add or change privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings. Existing privilege-related code in the file is unchanged and is not caused by this pull request.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only the context timeout from 20 to 25 minutes. The changed line adds no logging and does not expose passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Existing log statements in the file are unchanged and are not caused or worsened by this change.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[jacobsee]

/retest

[openshift-ci]

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jacobsee]

/retitle OCPBUGS-86789: Bump network config timeout to 25 minutes

[openshift-ci-robot]

@jacobsee: This pull request references Jira Issue OCPBUGS-86789, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is needed because KAS rollout on AWS now has a 300 sec (x3) rollout delay due to long LB drain times, which pushes the whole process now slightly over 20 min.

Summary by CodeRabbit

• Bug Fixes
• Increased the wait time for network configuration updates and kube-apiserver rollouts to reduce failures caused by slow operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.