WIP: OCPBUGS-86789: Revert "Make early request monitor test informing"

[jacobsee]

This reverts commit 1ec8531.

Summary by CodeRabbit

• Tests
  • Updated the API load balancer readiness test by removing obsolete test instrumentation.
  • No user-facing behavior changes.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jacobsee: This pull request references Jira Issue OCPBUGS-86789, which is invalid:

• expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 1ec8531.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 376d530e-672f-4dbb-a12a-93b58be0ddbe

📥 Commits

Reviewing files that changed from the base of the PR and between cc313a4 and 69efc3a.

📒 Files selected for processing (1)

• test/extended/apiserver/graceful_termination.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The API load balancer readiness test no longer imports openshift-tests-extension or applies the ote.Informing() label. The test logic remains unchanged.

Changes

API readiness test

Layer / File(s)	Summary
Remove unused test label test/extended/apiserver/graceful_termination.go	Removes the unused ote import and the ote.Informing() argument from the test declaration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 69efc

This is a localized test-only change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: reverting the commit that made the early request monitor test informing. This matches the removal of the ote import and ote.Informing() label.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request does not change any Ginkgo test title. The diff only removes the ote import and the ote.Informing() argument. The affected title remains the static string `API LBs follow /readyz …
Test Structure And Quality	✅ Passed	The pull request only removes the unused ote import and the ote.Informing() decorator from an existing Ginkgo It block. The test body, cluster operations, assertions, and messages are unchanged,…
Microshift Test Compatibility	✅ Passed	PASS: The pull request does not add a Ginkgo test or change test API usage. The exact diff only removes the unused ote import and ote.Informing() from an existing test. That test and its `Events("…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes the ote import and removes ote.Informing() from an existing g.It test. No new Ginkgo test is add…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes an unused ote import and the ote.Informing() label from a Ginkgo test. It does not add or modify d…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes the unused ote import and removes ote.Informing() from one g.It registration. It adds no stdout …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request only removes the unused ote import and the ote.Informing() label from an existing Ginkgo test. It adds no test and introduces no IPv4 address, IPv4-only parsing, URL constru…
No-Weak-Crypto	✅ Passed	PASS: The PR changes only test/extended/apiserver/graceful_termination.go. It removes the ote import and the ote.Informing() test label. No MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage, custom…
Container-Privileges	✅ Passed	PASS: The commit changes only test/extended/apiserver/graceful_termination.go. It removes an unused import and the ote.Informing() label. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SY…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The PR changes only the test classification and removes its unused ote import. It does not add logging or expose passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Exi…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Stable And Deterministic Test Names

Explanation

The pull request does not change any Ginkgo test title. The diff only removes the ote import and the ote.Informing() argument. The affected title remains the static string API LBs follow /readyz of kube-apiserver and don't send request early; the other titles are also static.

Full details: Test Structure And Quality

Explanation

The pull request only removes the unused ote import and the ote.Informing() decorator from an existing Ginkgo It block. The test body, cluster operations, assertions, and messages are unchanged, so the pull request does not introduce a failure under the stated test-structure requirements.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request does not add a Ginkgo test or change test API usage. The exact diff only removes the unused ote import and ote.Informing() from an existing test. That test and its Events("openshift-kube-apiserver") reference were present in HEAD^. The custom check applies to new Ginkgo e2e tests, so it does not identify a pull-request-introduced MicroShift compatibility failure.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes the ote import and removes ote.Informing() from an existing g.It test. No new Ginkgo test is added. The test body only lists API server events and checks the NonReadyRequests reason; it has no multi-node or HA assumption and no SNO guard is required.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes an unused ote import and the ote.Informing() label from a Ginkgo test. It does not add or modify deployment manifests, operator code, controllers, pod scheduling constraints, replica logic, node selectors, affinity, topology spread, or PDBs. The custom check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only test/extended/apiserver/graceful_termination.go. It removes the unused ote import and removes ote.Informing() from one g.It registration. It adds no stdout write and does not change process-level code. The current file has no main, TestMain, suite setup, logging, or stdout calls. Existing test-body output is outside this check's scope.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request only removes the unused ote import and the ote.Informing() label from an existing Ginkgo test. It adds no test and introduces no IPv4 address, IPv4-only parsing, URL construction, or external connectivity. The test only lists events through the cluster Kubernetes API.

Full details: No-Weak-Crypto

Explanation

PASS: The PR changes only test/extended/apiserver/graceful_termination.go. It removes the ote import and the ote.Informing() test label. No MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage, custom cryptography, or secret/token comparisons were introduced.

Full details: Container-Privileges

Explanation

PASS: The commit changes only test/extended/apiserver/graceful_termination.go. It removes an unused import and the ote.Informing() label. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root configuration, and it changes no container or Kubernetes manifest.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The PR changes only the test classification and removes its unused ote import. It does not add logging or expose passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Existing error output is unchanged and is not introduced by this PR.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobsee
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.