[OSDOCS-20065] Autonode preview - #116476
Conversation
EricPonvelle
added
do-not-merge/work-in-progress
openshift-ci
Bot
added
size/XXL
7c9225c to
402c0d3
Compare
|
🤖 Tue Jul 28 18:04:01 - Prow CI generated the docs preview: |
bchandra-ocp
left a comment
bchandra-ocp
left a comment
There was a problem hiding this comment.
(1/n) review. Working on the rest.
| @@ -93,11 +84,11 @@ $ aws iam attach-role-policy \ | |||
| --role-name rosa-karpenter-controller-role-${CLUSTER_NAME} \ | |||
| --policy-arn $POLICY_ARN | |||
There was a problem hiding this comment.
Instead of $POLICY_ARN, let's just use arn:aws:iam::aws:policy/service-role/ROSAKarpenterControllerPolicy which is the ARN for the AWS IAM Managed Policy. So the complete command will look as follows:
aws iam attach-role-policy \
--role-name rosa-autonode-operator-role \
--policy-arn arn:aws:iam::aws:policy/service-role/ROSAKarpenterControllerPolicy
402c0d3 to
ea03593
Compare
| --role-name rosa-karpenter-controller-role-${CLUSTER_NAME} \ | ||
| --policy-arn $POLICY_ARN | ||
| --role-name rosa-autonode-operator-role \ | ||
| --policy-arn arn:aws:iam::aws:policy/service-role/ROSAKarpenterControllerPolicy |
There was a problem hiding this comment.
@bchandra-ocp When I used the suggested command, I got:
aws iam attach-role-policy --role-name rosa-autonode-operator-role --policy-arn arn:aws:iam::aws:policy/service-role/ROSAKarpenterControllerPolicy
aws: [ERROR]: An error occurred (NoSuchEntity) when calling the AttachRolePolicy operation: The role with name rosa-autonode-operator-role cannot be found.
There was a problem hiding this comment.
@EricPonvelle You need to use the role you have used previously in the documentation: rosa-karpenter-controller-role-${CLUSTER_NAME}
"rosa-autonode-operator-role" is MY role. AWS only has managed policies.
ea03593 to
ec08af9
Compare
ec08af9 to
500c6cb
Compare
| * link:https://karpenter.sh/docs/[Karpenter project documentation] | ||
| * xref:../../upgrading/rosa-hcp-upgrading.adoc#rosa-upgrade-options_rosa-hcp-upgrading[Update options for {product-title} clusters configured with {autonode}] | ||
| * xref:../../support/troubleshooting/rosa-troubleshooting-autonode.adoc#rosa-troubleshooting-autonode[Troubleshoot {autonode} configuration and operational issues] | ||
| * link:https://github.com/openshift/hypershift/tree/main/api[HyperShift API Definitions Repository] |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
|
@EricPonvelle: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| - key: node.kubernetes.io/instance-type | ||
| operator: In | ||
| values: | ||
| - c5.xlarge |
There was a problem hiding this comment.
Since this spec also includes the "key" value, I believe you want to include your missing content here. So the spec for yaml would be:
spec:
template:
spec:
requirements:
- key: node.kubernetes.io/instance-type
operator: In
values:
- c5.xlarge
- key: karpenter.k8s.aws/instance-cpu
operator: Gte
values: ["4"]
- key: karpenter.sh/capacity-type
operator: In
values: ["on-demand"]
5 participants
Version(s):
enterprise-4.22+Issue:
https://redhat.atlassian.net/browse/OSDOCS-20065
Link to docs preview:
QE review:
Additional information:
This PR combines #115023, #115388, and #115441 to serve as a complete preview of the Autonode Fast Follow Updates.