Skip to content

NO-JIRA: do not fall back to the raw resource field for empty children #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XIANLIBO wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

NO-JIRA: do not fall back to the raw resource field for empty children #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils/components/DetailsItem/DetailsItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,11 @@ export const DetailsItem: FC<DetailsItemProps> = ({

const hide = hideEmpty && _.isEmpty(_.get(obj, path));
const popoverContent: string = description ?? getPropertyDescription(model, path);
const value: ReactNode = children || _.get(obj, path, defaultValue);
// Fall back to the raw resource field only when no children were provided at all.
// An empty or falsy child (for example a missing translation resolving to an empty
// string) must not fall through, otherwise a plain object such as
// metadata.annotations is handed to React as a child and the page crashes.
const value: ReactNode = children ?? _.get(obj, path, defaultValue);
const editable = onEdit && canEdit;

return hide ? null : (
Expand Down