USHIFT-7518: Support volume group snapshots by jsafrane · Pull Request #7381 · openshift/microshift

jsafrane · 2026-09-15T08:19:33Z

Summary

sync the CSI snapshot controller deployment arguments needed for volume group snapshots
install the VolumeGroupSnapshot, VolumeGroupSnapshotContent, and VolumeGroupSnapshotClass v1 CRDs
keep the auto-rebase asset recipe and post-processing aligned with the upstream snapshot controller operator
verify the group snapshot APIs and controller feature gate in the configuration test
confirm the existing controller RBAC already matches the upstream group snapshot permissions

Summary by CodeRabbit

New Features
- Added Kubernetes VolumeGroupSnapshot support for CSI storage.
- Added v1 resources for volume group snapshot classes, contents, and snapshots.
- Enabled the CSI volume group snapshot feature in the snapshot controller.
- Added validation for snapshot sources, references, deletion policies, and resource immutability.
Bug Fixes
- Improved snapshot controller request handling by configuring API request rate and burst limits.

Sync the CSI snapshot controller deployment and VolumeGroupSnapshot CRDs from the cluster CSI snapshot controller operator. Register the new APIs during startup and verify the controller feature gate in the configuration test. Refs: USHIFT-7518 Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Jan Safranek <jsafrane@redhat.com>

openshift-ci-robot · 2026-09-15T08:19:37Z

@jsafrane: This pull request references USHIFT-7518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

sync the CSI snapshot controller deployment arguments needed for volume group snapshots

install the VolumeGroupSnapshot, VolumeGroupSnapshotContent, and VolumeGroupSnapshotClass v1 CRDs

keep the auto-rebase asset recipe and post-processing aligned with the upstream snapshot controller operator

verify the group snapshot APIs and controller feature gate in the configuration test

confirm the existing controller RBAC already matches the upstream group snapshot permissions

Testing

go test ./pkg/assets ./pkg/components

make verify-sh

make verify-rf

python3 scripts/auto-rebase/presubmit.py

Robot Framework dry run of test/suites/configuration1/configuration.robot

YAML parsing and byte-for-byte upstream manifest comparisons

Jira

https://redhat.atlassian.net/browse/USHIFT-7518

Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-15T08:19:43Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-09-15T08:19:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 15d15ddc-9660-48a3-a43c-81eefab8826b

📥 Commits

Reviewing files that changed from the base of the PR and between c2c9986 and 91001c7.

📒 Files selected for processing (8)

assets/components/csi-snapshot-controller/csi_controller_deployment.yaml
assets/components/csi-snapshot-controller/volumegroupsnapshotclasses.yaml
assets/components/csi-snapshot-controller/volumegroupsnapshotcontents.yaml
assets/components/csi-snapshot-controller/volumegroupsnapshots.yaml
pkg/assets/crd.go
scripts/auto-rebase/assets.yaml
scripts/auto-rebase/rebase.sh
test/suites/configuration1/configuration.robot

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The change adds three v1 volume group snapshot CRDs, enables the controller feature gate and API request limits, registers the manifests, and validates the deployment configuration.

Changes

CSI volume group snapshot support

Layer / File(s)	Summary
Volume group snapshot CRD definitions `assets/components/csi-snapshot-controller/volumegroupsnapshotclasses.yaml`, `assets/components/csi-snapshot-controller/volumegroupsnapshotcontents.yaml`, `assets/components/csi-snapshot-controller/volumegroupsnapshots.yaml`	Adds the `VolumeGroupSnapshotClass`, `VolumeGroupSnapshotContent`, and `VolumeGroupSnapshot` CRDs. The v1 schemas include validation, status fields, and immutability rules. Beta versions remain commented out.
Controller configuration and asset registration `assets/components/csi-snapshot-controller/csi_controller_deployment.yaml`, `pkg/assets/crd.go`, `scripts/auto-rebase/assets.yaml`, `scripts/auto-rebase/rebase.sh`	Enables `CSIVolumeGroupSnapshot`, sets API QPS to 30 and burst to 60, and registers the three CRD manifests.
Deployment support validation `test/suites/configuration1/configuration.robot`	Checks that the three CRDs exist and that the controller deployment enables `CSIVolumeGroupSnapshot=true`.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: pacevedom

Merge Risk: ⚪ Minimal · up to 91001

The group snapshot assets, registration, controller configuration, and validation are consistent, with no actionable merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (6 skipped: 6 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request adds a static Robot Framework keyword name, `CSI Volume Group Snapshot Support Is Enabled`, and invokes it from the existing static test case. The added test body uses fixed CRD…
Test Structure And Quality	✅ Passed	PASS: The pull request does not add or modify Ginkgo tests or Go `It` blocks. Its only test change is a Robot Framework keyword in `test/suites/configuration1/configuration.robot`, so the Ginkgo-speci…
Microshift Test Compatibility	✅ Passed	The pull request adds no Ginkgo e2e tests. The only changed test file is a Robot Framework configuration test, and the changed Go file only registers CRD assets. Therefore, the MicroShift Test Compati…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no new Ginkgo e2e tests. The only changed test file is a Robot Framework configuration suite, and the remaining changes are YAML manifests or asset-registration code. There…
Topology-Aware Scheduling Compatibility	✅ Passed	No topology scheduling constraint is introduced. The deployment diff adds only `-kube-api-qps=30`, `-kube-api-burst=60`, and `CSIVolumeGroupSnapshot=true`. Its existing `maxUnavailable: 1`, preferred …
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request does not add or modify OTE process-level Go code. The only Go change adds three CRD path strings to the existing `crds` variable initializer in `pkg/assets/crd.go`; it adds no s…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR adds no Ginkgo e2e tests. The only test change is a Robot Framework keyword that queries in-cluster CRDs and the CSI snapshot controller deployment. It adds no IPv4 assumptions and no ext…
No-Weak-Crypto	✅ Passed	PASS: The PR adds Kubernetes CRDs, controller arguments, asset registrations, and a configuration test. The changed Go file only adds CRD asset paths. The changed shell and YAML files contain no MD5, …
Container-Privileges	✅ Passed	No custom-check violation is introduced. The deployment diff adds only API QPS, burst, and feature-gate arguments. Its existing security context remains non-root (`runAsNonRoot: true`, `runAsUser: 655…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request adds CRD schemas, controller arguments, asset registrations, and configuration checks. It does not add logging calls or log sensitive values. The Robot test reads only CRD names and t…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding support for volume group snapshots.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

jsafrane · 2026-09-15T08:21:16Z

+            - -kube-api-qps=30
+            - -kube-api-burst=60


This is now present in OpenShift's yaml files, see openshift/cluster-csi-snapshot-controller-operator#261
It's probably unnecessary in Microshift - the load won't be that high. On the other hand, it should not harm anything. I kept it to be in sync with OpenShift.

jsafrane · 2026-09-15T08:24:27Z

/payload-job periodic-ci-openshift-microshift-release-5.1-periodics-e2e-aws-ovn-ocp-conformance

openshift-ci · 2026-09-15T08:24:36Z

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-microshift-release-5.1-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/de3af4b0-b0de-11f1-8e12-95ca108e7c48-0

pacevedom · 2026-09-15T10:40:20Z

/test test-unit

jsafrane · 2026-09-15T10:59:41Z

I would cosider the bug as fixed - group snapshot tests passed in microshift-main-ocp-full-conformance-rhel-eus, while they failed in an unrelated PR.

pacevedom · 2026-09-15T11:12:39Z

/pipeline auto

openshift-ci · 2026-09-15T11:12:44Z

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

openshift-ci · 2026-09-15T11:12:45Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc-arm-el10
/test e2e-aws-tests-bootc-arm-el9
/test e2e-aws-tests-bootc-el10
/test e2e-aws-tests-bootc-el9

openshift-merge-bot · 2026-09-15T11:17:39Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc-arm-el10
/test e2e-aws-tests-bootc-arm-el9
/test e2e-aws-tests-bootc-el10
/test e2e-aws-tests-bootc-el9

pacevedom · 2026-09-15T14:39:19Z

/test e2e-aws-tests

pacevedom · 2026-09-15T19:52:08Z

/test e2e-aws-tests

pacevedom · 2026-09-16T07:58:10Z

/override ci/prow/e2e-aws-tests
/override ci/prow/e2e-aws-tests-arm

Unrelated tuned issues

openshift-ci · 2026-09-16T07:59:18Z

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm

Details

In response to this:

/override ci/prow/e2e-aws-tests
/override ci/prow/e2e-aws-tests-arm

Unrelated tuned issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pacevedom

/lgtm

pacevedom · 2026-09-16T08:05:37Z

/verified by CI

openshift-ci-robot · 2026-09-16T08:05:49Z

@pacevedom: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-16T08:09:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-09-16T10:01:16Z

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pacevedom · 2026-09-16T10:37:35Z

/cherry-pick release-5.0

openshift-cherrypick-robot · 2026-09-16T10:38:43Z

@pacevedom: new pull request created: #7385

Details

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 15, 2026

openshift-ci Bot requested review from kasturinarra and pacevedom September 15, 2026 08:20

jsafrane commented Sep 15, 2026

View reviewed changes

coderabbitai Bot approved these changes Sep 15, 2026

View reviewed changes

openshift-ci Bot added the pipeline-auto label Sep 15, 2026

pacevedom mentioned this pull request Sep 15, 2026

OCPEDGE-2997: Add PKI certificate inventory #7350

Merged

pacevedom approved these changes Sep 16, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2026

openshift-ci Bot assigned pacevedom Sep 16, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026

openshift-merge-bot Bot merged commit 7295d8c into openshift:main Sep 16, 2026
16 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 16, 2026

[release-5.0] USHIFT-7518: Support volume group snapshots #7385

Merged

Conversation

jsafrane commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Sep 15, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Jira

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

coderabbitai Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

jsafrane Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

jsafrane commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

pacevedom commented Sep 15, 2026

Uh oh!

jsafrane commented Sep 15, 2026

Uh oh!

pacevedom commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 15, 2026

Uh oh!

pacevedom commented Sep 15, 2026

Uh oh!

pacevedom commented Sep 15, 2026

Uh oh!

pacevedom commented Sep 16, 2026

Uh oh!

openshift-ci Bot commented Sep 16, 2026

Uh oh!

pacevedom left a comment

Choose a reason for hiding this comment

Uh oh!

pacevedom commented Sep 16, 2026

Uh oh!

openshift-ci-robot commented Sep 16, 2026

Uh oh!

openshift-ci Bot commented Sep 16, 2026

Uh oh!

openshift-ci Bot commented Sep 16, 2026

Uh oh!

Uh oh!

pacevedom commented Sep 16, 2026

Uh oh!

openshift-cherrypick-robot commented Sep 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jsafrane commented Sep 15, 2026 •

edited

Loading

openshift-ci-robot commented Sep 15, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading