test: add SSH wait-for-ready retries to SOS artifact collection - #7375
redhat-chai-bot wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…lection When a VM is rebooting (e.g. after a low-latency/RT kernel switch), SSH may be temporarily unavailable, causing copy_file_from_vm calls to fail silently and diagnostic artifacts (SOS reports, journal logs, anaconda logs) to be lost. Add an SSH connectivity wait loop at the top of sos_report_for_vm() that polls SSH with a 10s connect timeout and 5s backoff for up to 120 seconds. This is shorter than the full VM_BOOT_TIMEOUT (1200s) to avoid blocking the pipeline while still riding out quick reboots. If SSH never comes back, a warning is logged and the function returns cleanly without attempting the copy operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4802137 to
cab20c0
Compare
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Add an SSH connectivity wait at the top of
sos_report_for_vm()before attempting to copy diagnostic artifacts (SOS reports, journal logs, anaconda logs) from the VM.Problem
In scenarios where the VM reboots (e.g. low-latency/RT kernel configuration via greenboot), SSH may be temporarily unavailable when
sos_report_for_vm()runs. The existing code does single-shotscp/sshattempts and silently discards the diagnostic artifacts on failure, making post-mortem debugging harder.Example failure:
Fix
sos_report_for_vm()with a 120-second timeout (10s connect timeout per attempt, 5s backoff)wait_for_ssh()helper, plus the VM's configured SSH portThis is a minimal, focused change — only
test/bin/scenario.shis modified.AI-generated. Review for accuracy.
@pmtk requested via Chai Bot
Warning
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (
never_attempted), so it has not been checked for credentials or malware.Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.