OCPBUGS-119104: drop GCD health-check ranges in openshift-gcp-routes by patrickdillon · Pull Request #6555 · openshift/machine-config-operator

patrickdillon · 2026-09-17T18:29:27Z

Manual cherrypick of #6501

What I did
Updated the pattern introduced by the bug fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1925698 and https://bugzilla.redhat.com/show_bug.cgi?id=1930457 to take into account the health probe ranges for GCD sovereign regions.
How to verify it
We have gcd e2e jobs, and I will kick one off, but I'm not certain the file in question would be gathered in CI artifacts. If not, I will manually verify (and update here of course).
Description for the changelog

Include GCD health-check probe ranges in openshift-gcp-routes.

openshift-gcp-routes drops load balancer health-check probes that would be forwarded off-node, to avoid polluting conntrack (BZ 1925698, 1930457). The dropped source ranges were hardcoded to the public GCP prober ranges (35.191.0.0/16, 130.211.0.0/22). GCD (sovereign) regions probe from different ranges which need to be added to avoid the issue seen on public GCP. Select the dropped ranges by region via a new gcpHealthCheckSourceRanges template function: GCD regions drop their own region's prober ranges, all other regions keep the public GCP behavior. Only ranges reserved for health-check probers in the target environment are dropped -- a range that is reserved prober infrastructure in one environment is ordinary routable space in another, so the ranges must not be dropped unconditionally.

Bump openshift/api to bring in most up-to-date feature gates.

go mod vendor

openshift-merge-bot · 2026-09-17T18:29:30Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-09-17T18:29:33Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 70446233-1ad7-41dc-97a6-a3a26170f838

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

patrickdillon · 2026-09-17T18:29:45Z

/jira cherrypick OCPBUGS-114882

openshift-ci-robot · 2026-09-17T18:29:49Z

@patrickdillon: Detected clone of Jira Issue OCPBUGS-114882 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-119104: drop GCD health-check ranges in openshift-gcp-routes

Details

In response to this:

/jira cherrypick OCPBUGS-114882

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-09-17T18:30:00Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-119104, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
expected dependent Jira Issue OCPBUGS-114882 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What I did
Updated the pattern introduced by the bug fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1925698 and https://bugzilla.redhat.com/show_bug.cgi?id=1930457 to take into account the health probe ranges for GCD sovereign regions.

How to verify it
We have gcd e2e jobs, and I will kick one off, but I'm not certain the file in question would be gathered in CI artifacts. If not, I will manually verify (and update here of course).

Description for the changelog

Include GCD health-check probe ranges in openshift-gcp-routes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-09-18T15:23:05Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-119104, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Manual cherrypick of #6501

What I did
Updated the pattern introduced by the bug fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1925698 and https://bugzilla.redhat.com/show_bug.cgi?id=1930457 to take into account the health probe ranges for GCD sovereign regions.

How to verify it
We have gcd e2e jobs, and I will kick one off, but I'm not certain the file in question would be gathered in CI artifacts. If not, I will manually verify (and update here of course).

Description for the changelog

Include GCD health-check probe ranges in openshift-gcp-routes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2026-09-18T15:23:19Z

/jira refresh

openshift-ci-robot · 2026-09-18T15:23:23Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-119104, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2026-09-18T15:23:27Z

/retest-required

patrickdillon · 2026-09-18T15:23:31Z

/skip

patrickdillon · 2026-09-18T15:24:43Z

Not sure if we landed on payload jobs will never work or if it was a temporary issue. lemme retry

patrickdillon · 2026-09-18T15:24:54Z

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn

openshift-ci · 2026-09-18T15:24:58Z

@patrickdillon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/198f8e20-b375-11f1-9d63-ef7b1b814698-0

tthvo · 2026-09-18T18:31:45Z

/jira refresh

openshift-ci-robot · 2026-09-18T18:31:52Z

@tthvo: This pull request references Jira Issue OCPBUGS-119104, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-114882 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-114882 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-09-18T18:32:12Z

/cc @yuqi-zhang

patrickdillon · 2026-09-21T14:46:29Z

/verified by payload test

openshift-ci-robot · 2026-09-21T14:46:41Z

@patrickdillon: This PR has been marked as verified by payload test.

Details

In response to this:

/verified by payload test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang

/lgtm
/label backport-risk-assessed

Seems like this matches the head of the 5.0 API branch, so should be a safe backport

openshift-merge-bot · 2026-09-21T16:23:05Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift
/test tls-pqc-readiness

openshift-ci · 2026-09-21T16:23:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

patrickdillon · 2026-09-21T16:50:27Z

/test unit

yuqi-zhang · 2026-09-21T17:58:53Z

/override ci/prow/unit

Unrelated failure

openshift-ci · 2026-09-21T18:00:09Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/unit

Details

In response to this:

/override ci/prow/unit

Unrelated failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-bot · 2026-09-21T20:00:32Z

/retest-required

Remaining retests: 0 against base HEAD 00d161b and 2 for PR HEAD 0e8e5c6 in total

patrickdillon · 2026-09-21T21:45:25Z

/jira refresh

openshift-ci-robot · 2026-09-21T21:45:30Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-119104, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-114882 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-114882 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-09-21T23:24:47Z

/test e2e-gcp-op-ocl-part2

yuqi-zhang · 2026-09-22T00:12:12Z

/override ci/prow/e2e-gcp-op-ocl-part2

Looks like a timeout, and anyways this should be unable to affect that job, unless this causes any slowdowns on general GCP platforms, which I don't think should be the case

openshift-ci · 2026-09-22T00:20:25Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-ocl-part2

Details

In response to this:

/override ci/prow/e2e-gcp-op-ocl-part2

Looks like a timeout, and anyways this should be unable to affect that job, unless this causes any slowdowns on general GCP platforms, which I don't think should be the case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tthvo · 2026-09-22T03:22:02Z

/test bootstrap-unit

openshift-ci · 2026-09-22T03:38:41Z

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-09-22T03:41:33Z

@patrickdillon: Jira Issue Verification Checks: Jira Issue OCPBUGS-119104
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-119104 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherrypick of #6501

What I did
Updated the pattern introduced by the bug fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1925698 and https://bugzilla.redhat.com/show_bug.cgi?id=1930457 to take into account the health probe ranges for GCD sovereign regions.

How to verify it
We have gcd e2e jobs, and I will kick one off, but I'm not certain the file in question would be gathered in CI artifacts. If not, I will manually verify (and update here of course).

Description for the changelog

Include GCD health-check probe ranges in openshift-gcp-routes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-09-23T09:02:30Z

Fix included in release 5.0.0-0.nightly-2026-09-23-031212

patrickdillon added 3 commits September 17, 2026 14:26

go.mod: bump openshift/api

ff0564f

Bump openshift/api to bring in most up-to-date feature gates.

vendor: openshift/api

0e8e5c6

go mod vendor

openshift-ci Bot changed the title ~~drop GCD health-check ranges in openshift-gcp-routes~~ OCPBUGS-119104: drop GCD health-check ranges in openshift-gcp-routes Sep 17, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 17, 2026

openshift-ci Bot requested review from djoshy and ptalgulk01 September 17, 2026 18:30

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 18, 2026

openshift-ci Bot requested a review from yuqi-zhang September 18, 2026 18:32

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 21, 2026

patrickdillon mentioned this pull request Sep 21, 2026

OCPBUGS-119240: drop GCD health-check ranges in openshift-gcp-routes #6564

Merged

yuqi-zhang approved these changes Sep 21, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 21, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, mhanss, ptalgulk01, rbbratta, sergiordlr and yuqi-zhang Sep 21, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026

openshift-merge-bot Bot merged commit 1f4f3e7 into openshift:release-5.0 Sep 22, 2026
21 checks passed

Conversation

patrickdillon commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

coderabbitai Bot commented Sep 17, 2026

Review skipped

Uh oh!

patrickdillon commented Sep 17, 2026

Uh oh!

openshift-ci-robot commented Sep 17, 2026

Uh oh!

openshift-ci-robot commented Sep 17, 2026

Uh oh!

openshift-ci-robot commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 18, 2026

Uh oh!

openshift-ci-robot commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 18, 2026

Uh oh!

openshift-ci Bot commented Sep 18, 2026

Uh oh!

tthvo commented Sep 18, 2026

Uh oh!

openshift-ci-robot commented Sep 18, 2026

Uh oh!

tthvo commented Sep 18, 2026

Uh oh!

patrickdillon commented Sep 21, 2026

Uh oh!

openshift-ci-robot commented Sep 21, 2026

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Sep 21, 2026

Uh oh!

openshift-ci Bot commented Sep 21, 2026

Uh oh!

patrickdillon commented Sep 21, 2026

Uh oh!

yuqi-zhang commented Sep 21, 2026

Uh oh!

openshift-ci Bot commented Sep 21, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 21, 2026

Uh oh!

patrickdillon commented Sep 21, 2026

Uh oh!

openshift-ci-robot commented Sep 21, 2026

Uh oh!

tthvo commented Sep 21, 2026

Uh oh!

yuqi-zhang commented Sep 22, 2026

Uh oh!

openshift-ci Bot commented Sep 22, 2026

Uh oh!

tthvo commented Sep 22, 2026

Uh oh!

openshift-ci Bot commented Sep 22, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 22, 2026

Uh oh!

openshift-merge-robot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

patrickdillon commented Sep 17, 2026 •

edited

Loading