Skip to content

WIP: SPLAT-2964: use component credentials for installer operations - #10895

Draft
rvanderp3 wants to merge 1 commit into
openshift:mainfrom
rvanderp3:SPLAT-2964
Draft

rvanderp3 wants to merge 1 commit into
openshift:mainfrom
rvanderp3:SPLAT-2964

Conversation

@rvanderp3

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds support for component-scoped vSphere credentials in the installer.

The new platform.vsphere.credentialType: component-scoped mode allows separate credentials for:

  • Machine API and Cluster API / installer-side VM operations
  • vSphere CSI
  • vSphere Cloud Controller Manager
  • vSphere Problem Detector

CAPI and other installer-side operations use the machine-management credential. Component-specific credentials are emitted to the exact Secret namespaces and names expected by the corresponding OpenShift operators.

Global credentials remain supported for backward compatibility.

Changes

  • Add vSphere component credential types and validation.
  • Use machine-management credentials for CAPI-generated vSphere identity Secrets.
  • Generate component-specific Secrets for vSphere manual credentials mode.
  • Redact all component credentials from the rendered install configuration.
  • Update the install-config schema and vSphere customization documentation.
  • Add tests covering:
  • Credential selection for global and component-scoped modes.
  • Component credential validation.
  • CAPI credential Secret generation.
  • Manual Secret generation and target namespaces.
  • Sensitive credential redaction.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2026
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@rvanderp3: This pull request references SPLAT-2964 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

What does this PR do?

Adds support for component-scoped vSphere credentials in the installer.

The new platform.vsphere.credentialType: component-scoped mode allows separate credentials for:

  • Machine API and Cluster API / installer-side VM operations
  • vSphere CSI
  • vSphere Cloud Controller Manager
  • vSphere Problem Detector

CAPI and other installer-side operations use the machine-management credential. Component-specific credentials are emitted to the exact Secret namespaces and names expected by the corresponding OpenShift operators.

Global credentials remain supported for backward compatibility.

Changes

  • Add vSphere component credential types and validation.
  • Use machine-management credentials for CAPI-generated vSphere identity Secrets.
  • Generate component-specific Secrets for vSphere manual credentials mode.
  • Redact all component credentials from the rendered install configuration.
  • Update the install-config schema and vSphere customization documentation.
  • Add tests covering:
  • Credential selection for global and component-scoped modes.
  • Component credential validation.
  • CAPI credential Secret generation.
  • Manual Secret generation and target namespaces.
  • Sensitive credential redaction.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 948f8805-bb31-4631-905e-378ef7f104e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants