OCPBUGS-126706: azure: allow isolated Ebdsv5/Ebsv5 VM families

[nikhilprajapati-world]

Summary

• Install-config validation no longer hard-fails isolated Ebdsv5/Ebsv5 families (standardEIBDSv5Family / standardEIBSv5Family), which docs/user/azure/tested_instance_types_x86_64.md already lists as tested.
• The block was added for Terraform (OCPBUGS-18690 / terraform-provider-azurerm#22058). Azure IPI now provisions via CAPI, and gallery images advertise NVMe disk controllers.
• Windows-only standardNVSv4Family is still rejected.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-126706

Test plan

• go test ./pkg/asset/installconfig/azure -run TestValidateFamilyIsolatedEbdsv5Allowed
• Azure IPI install-config.yaml with controlPlane.platform.azure.type: Standard_E112ibds_v5 and compute[0].platform.azure.type: Standard_E112ibs_v5 loads Install Config (no "not currently supported" family error)
• Shared sibling Standard_E16bds_v5 (standardEBDSv5Family) still validates
• Windows-only family standardNVSv4Family is still rejected

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
  • Azure installation validation now accepts additional EBD(S) v5 VM families.
  • Windows-only VM family restrictions remain unchanged.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@nikhilprajapati-world: This pull request references Jira Issue OCPBUGS-126706, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Install-config validation no longer hard-fails isolated Ebdsv5/Ebsv5 families (standardEIBDSv5Family / standardEIBSv5Family), which docs/user/azure/tested_instance_types_x86_64.md already lists as tested.
• The block was added for Terraform (OCPBUGS-18690 / terraform-provider-azurerm#22058). Azure IPI now provisions via CAPI, and gallery images advertise NVMe disk controllers.
• Windows-only standardNVSv4Family is still rejected.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-126706

Test plan

• go test ./pkg/asset/installconfig/azure -run TestValidateFamilyIsolatedEbdsv5Allowed
• Azure IPI install-config.yaml with controlPlane.platform.azure.type: Standard_E112ibds_v5 and compute[0].platform.azure.type: Standard_E112ibs_v5 loads Install Config (no "not currently supported" family error)
• Shared sibling Standard_E16bds_v5 (standardEBDSv5Family) still validates
• Windows-only family standardNVSv4Family is still rejected

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 3662bcce-331f-4c00-9b73-3dab354539e8

📥 Commits

Reviewing files that changed from the base of the PR and between 91cd2fe and a85f3ae.

📒 Files selected for processing (2)

• pkg/asset/installconfig/azure/validation.go
• pkg/asset/installconfig/azure/validation_test.go

💤 Files with no reviewable changes (1)

• pkg/asset/installconfig/azure/validation.go

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Azure family validation

Layer / File(s)	Summary
Allow Ebdsv5 families and validate instance types pkg/asset/installconfig/azure/validation.go, pkg/asset/installconfig/azure/validation_test.go	validateFamily now accepts standardEIBDSv5Family and standardEIBSv5Family. Tests cover these families and standardEBDSv5Family through ValidateInstanceType. The Windows-only rejection remains covered.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a85f3

The newly allowed Azure VM families retain normal compatibility validation, with coverage for the accepted families and the Windows-only rejection. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request adds only static test names. TestValidateFamilyIsolatedEbdsv5Allowed is fixed, and its subtest names (isolated Ebdsv5, isolated Ebsv5, shared Ebdsv5, and `windows-only family …
Test Structure And Quality	✅ Passed	PASS. The custom check targets Ginkgo test code, but this PR adds a standard Go testing test in pkg/asset/installconfig/azure/validation_test.go; it uses t.Run, not Ginkgo It, BeforeEach, `A…
Microshift Test Compatibility	✅ Passed	The pull request adds a standard Go unit test, TestValidateFamilyIsolatedEbdsv5Allowed, in pkg/asset/installconfig/azure/validation_test.go. It does not add Ginkgo e2e tests (It, Describe, `Co…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds a standard Go testing unit test, TestValidateFamilyIsolatedEbdsv5Allowed, in pkg/asset/installconfig/azure/validation_test.go. It adds no Ginkgo It, Describe, `Co…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request changes only Azure install-config family validation and its unit test. The diff removes a VM-family rejection and adds validation coverage. It adds no deployment manifests, ope…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only Azure family validation and a unit test. The patch adds no fmt/log/klog stdout writes, os.Stdout use, output redirection, or Ginkgo suite setup. The new code runs i…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds a standard Go unit test, TestValidateFamilyIsolatedEbdsv5Allowed, not a Ginkgo e2e test. The added test uses mocks and local validation only. It contains no hardcoded IPv4 addr…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only Azure VM-family validation and tests. The diff adds no cryptographic algorithms, modes, custom crypto, or secret/token comparisons. The only des matches are exist…
Container-Privileges	✅ Passed	PASS. The pull request changes only Azure Go validation code and its Go test. The diff adds no container or Kubernetes manifest and introduces none of the listed conditions: privileged containers, hos…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only Azure family validation and tests. The diff adds no logging, diagnostic output, or sensitive-data handling. The new test uses public VM SKU and capability values on…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: allowing isolated Azure Ebdsv5 and Ebsv5 VM families.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/azure/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@nikhilprajapati-world: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

• Install-config validation no longer hard-fails isolated Ebdsv5/Ebsv5 families (standardEIBDSv5Family / standardEIBSv5Family), which docs/user/azure/tested_instance_types_x86_64.md already lists as tested.
• The block was added for Terraform (OCPBUGS-18690 / terraform-provider-azurerm#22058). Azure IPI now provisions via CAPI, and gallery images advertise NVMe disk controllers.
• Windows-only standardNVSv4Family is still rejected.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-126706

Test plan

• go test ./pkg/asset/installconfig/azure -run TestValidateFamilyIsolatedEbdsv5Allowed
• Azure IPI install-config.yaml with controlPlane.platform.azure.type: Standard_E112ibds_v5 and compute[0].platform.azure.type: Standard_E112ibs_v5 loads Install Config (no "not currently supported" family error)
• Shared sibling Standard_E16bds_v5 (standardEBDSv5Family) still validates
• Windows-only family standardNVSv4Family is still rejected

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
• Azure installation validation now accepts additional EBD(S) v5 VM families.
• Windows-only VM family restrictions remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/retitle OCPBUGS-126706: azure: allow isolated Ebdsv5/Ebsv5 VM families

We just need to add the target version :D

[openshift-ci-robot]

@nikhilprajapati-world: This pull request references Jira Issue OCPBUGS-126706, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

• Install-config validation no longer hard-fails isolated Ebdsv5/Ebsv5 families (standardEIBDSv5Family / standardEIBSv5Family), which docs/user/azure/tested_instance_types_x86_64.md already lists as tested.
• The block was added for Terraform (OCPBUGS-18690 / terraform-provider-azurerm#22058). Azure IPI now provisions via CAPI, and gallery images advertise NVMe disk controllers.
• Windows-only standardNVSv4Family is still rejected.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-126706

Test plan

• go test ./pkg/asset/installconfig/azure -run TestValidateFamilyIsolatedEbdsv5Allowed
• Azure IPI install-config.yaml with controlPlane.platform.azure.type: Standard_E112ibds_v5 and compute[0].platform.azure.type: Standard_E112ibs_v5 loads Install Config (no "not currently supported" family error)
• Shared sibling Standard_E16bds_v5 (standardEBDSv5Family) still validates
• Windows-only family standardNVSv4Family is still rejected

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
• Azure installation validation now accepts additional EBD(S) v5 VM families.
• Windows-only VM family restrictions remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/test e2e-azure-ovn azure-private

[openshift-ci]

@nikhilprajapati-world: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

/lgtm

Based on the result of azure-ipi-all-instance-types, this looks good :D The spec is as followed:

Region: eastus2
Control plane: Standard_E4bds_v5 (standardEIBDSv5Family)
Compute: Standard_E4bs_v5 (standardEIBSv5Family) 

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-azure-default-config
/test e2e-azure-ovn
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-aws-ovn

[tthvo]

/override-sticky ci/prow/e2e-aws-ovn

Changes are unrelated to AWS platform. I'm overriding as we are hitting load balancer quota.

[openshift-ci]

@tthvo: Overrode contexts on behalf of tthvo: ci/prow/e2e-aws-ovn

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/e2e-aws-ovn

Changes are unrelated to AWS platform. I'm overriding as we are hitting load balancer quota.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@nikhilprajapati-world: This pull request references Jira Issue OCPBUGS-126706, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

• Install-config validation no longer hard-fails isolated Ebdsv5/Ebsv5 families (standardEIBDSv5Family / standardEIBSv5Family), which docs/user/azure/tested_instance_types_x86_64.md already lists as tested.
• The block was added for Terraform (OCPBUGS-18690 / terraform-provider-azurerm#22058). Azure IPI now provisions via CAPI, and gallery images advertise NVMe disk controllers.
• Windows-only standardNVSv4Family is still rejected.

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-126706

Test plan

• go test ./pkg/asset/installconfig/azure -run TestValidateFamilyIsolatedEbdsv5Allowed
• Azure IPI install-config.yaml with controlPlane.platform.azure.type: Standard_E112ibds_v5 and compute[0].platform.azure.type: Standard_E112ibs_v5 loads Install Config (no "not currently supported" family error)
• Shared sibling Standard_E16bds_v5 (standardEBDSv5Family) still validates
• Windows-only family standardNVSv4Family is still rejected

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
• Azure installation validation now accepts additional EBD(S) v5 VM families.
• Windows-only VM family restrictions remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.