Skip to content

[release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0) - #1630

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-5.0from
openshift-cherrypick-robot:cherry-pick-1590-to-release-5.0
Open

[release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)#1630
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-5.0from
openshift-cherrypick-robot:cherry-pick-1590-to-release-5.0

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #1590

/assign Tal-or

  Add a new performance-profile-creator flag, --ovs-dpdk-cpu-count, that
  reserves a dedicated set of CPUs for OVS-DPDK PMD threads and populates
  spec.cpu.ovsDpdk on the generated PerformanceProfile. It defaults to 0,
  leaving existing behavior unchanged.

  CalculateCPUSets now also returns the OVS-DPDK cpuset. Selection happens
  after reserved and offlined CPUs are chosen, drawing only from cores not
  already claimed, and the resulting CPUs are excluded from the isolated
  set. Allocation mirrors the reserved-CPU hyperthreading rules: with HT
  enabled it takes whole sibling groups and requires an even count; with
  HT off (or --disable-ht) it takes one logical processor per core.

Signed-off-by: Tomer Avital <tavital@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNF-26060

Details

In response to this:

This is an automated cherry-pick of #1590

/assign Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5c15f067-d8da-4e4a-8e92-4c0957691a27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from MarSik and ffromani September 3, 2026 08:07
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tal-or

Tal-or commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/retitle [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)](#1630 (comment))

@openshift-ci openshift-ci Bot changed the title [release-5.0] CNF-26060: add optional --ovs-dpdk-cpu-count flag (default 0) [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)](https://github.com/openshift/cluster-node-tuning-operator/pull/1630#top) Sep 3, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-119931, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-119931 to depend on a bug targeting a version in 5.1.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1590

/assign Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or

Tal-or commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/retitle [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)

@openshift-ci openshift-ci Bot changed the title [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)](https://github.com/openshift/cluster-node-tuning-operator/pull/1630#top) [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0) Sep 3, 2026
@Tal-or

Tal-or commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/jira-refresh
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-techpreview
/test e2e-gcp-pao
/test e2e-gcp-pao-updating-profile
/test e2e-gcp-pao-workloadhints
/test e2e-hypershift
/test e2e-hypershift-pao
/test e2e-no-cluster
/test e2e-upgrade

@Tal-or

Tal-or commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/jira-refresh

@Tal-or

Tal-or commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Tal-or: This pull request references Jira Issue OCPBUGS-119931, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-119930 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-119930 targets the "5.1" version, which is one of the valid target versions: 5.1.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants