[release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0) - #1630
Conversation
Add a new performance-profile-creator flag, --ovs-dpdk-cpu-count, that reserves a dedicated set of CPUs for OVS-DPDK PMD threads and populates spec.cpu.ovsDpdk on the generated PerformanceProfile. It defaults to 0, leaving existing behavior unchanged. CalculateCPUSets now also returns the OVS-DPDK cpuset. Selection happens after reserved and offlined CPUs are chosen, drawing only from cores not already claimed, and the resulting CPUs are excluded from the isolated set. Allocation mirrors the reserved-CPU hyperthreading rules: with HT enabled it takes whole sibling groups and requires an even count; with HT off (or --disable-ht) it takes one logical processor per core. Signed-off-by: Tomer Avital <tavital@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNF-26060 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0)](#1630 (comment)) |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-119931, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-5.0] OCPBUGS-119931: add optional --ovs-dpdk-cpu-count flag (default 0) |
|
/jira-refresh |
|
Scheduling required tests: |
|
/jira-refresh |
|
/jira refresh |
|
@Tal-or: This pull request references Jira Issue OCPBUGS-119931, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #1590
/assign Tal-or