OCPBUGS-116703: E2E: add missing matcher to offlined CPU Expect() calls

[oblau]

Expect(bool) without .To() is a no-op; these tests never fail on these assertions.

Summary by CodeRabbit

• Tests
  • Improved end-to-end performance profile test failures by including the expected and actual offlined CPU sets in assertion messages.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@oblau: This pull request references Jira Issue OCPBUGS-116703, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Expect(bool) without .To() is a no-op; these tests never fail on these assertions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 2fc03b8f-b5eb-4282-956d-6cb9824894c6

📥 Commits

Reviewing files that changed from the base of the PR and between 246b707 and 83313db.

📒 Files selected for processing (1)

• test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

Changes

Offlined CPU assertion diagnostics

Layer / File(s)	Summary
Add offlined CPU assertion messages test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go	Five offlined CPU equality assertions now report the expected and actual CPU sets when they fail.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 83313

This localized test change restores the missing matchers so the affected assertions can fail correctly; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mrniranjan

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only five existing Expect(...).To(BeTrue(), ...) assertions in updating_profile.go. The Describe, Context, and It titles are unchanged and use static string li…
Test Structure And Quality	✅ Passed	PASS. The commit changes only five existing offlined-CPU assertions. Each now uses .To(BeTrue(), ...) and reports the expected and actual CPU sets. This satisfies the assertion-message requirement a…
Microshift Test Compatibility	✅ Passed	PASS: The pull request does not add new Ginkgo tests. The diff changes only five existing Expect(...) assertions in updating_profile.go by adding .To(BeTrue(), ...). Ginkgo declaration counts re…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request does not add a Ginkgo e2e test or change test topology assumptions. The diff changes only five existing Expect(...) assertions in the existing Offlined CPU API tests by addi…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only five Gomega assertions in test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go. The diff adds .To(BeTrue(), ...) to CPU-set checks. It…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only five Expect(...).To(BeTrue(), ...) assertions in It test bodies. The added code writes no stdout and does not modify main(), suite setup, logging configuratio…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request does not add new Ginkgo tests or network operations. The diff only changes five existing Expect(offlinedCPUSet.Equals(...)) assertions to use .To(BeTrue(), ...). The Ginkgo …
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only five Gomega assertions in updating_profile.go. The exact diff adds .To(BeTrue(), ...) and CPU-set diagnostic text. It introduces no MD5, SHA1, DES, RC4, 3DES, B…
Container-Privileges	✅ Passed	PASS: The pull request changes only five Gomega assertions in one Go e2e test file. The diff adds .To(BeTrue(), ...) and does not add privileged, host PID/network/IPC settings, SYS_ADMIN, `allow…
No-Sensitive-Data-In-Logs	✅ Passed	PASS — The pull request adds only a Gomega failure message that reports expected and actual offline CPU sets. The vendored CPUSet.String() representation contains CPU IDs and ranges only. No passwor…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: adding the missing matcher to five offlined CPU E2E assertions.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@oblau: This pull request references Jira Issue OCPBUGS-116703, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Expect(bool) without .To() is a no-op; these tests never fail on these assertions.

Summary by CodeRabbit

• Tests
• Improved end-to-end performance profile test failures by including the expected and actual offlined CPU sets in assertion messages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oblau
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oblau]

/retest

[openshift-ci]

@oblau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	83313db	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[oblau]

/verified by oblau

[openshift-ci-robot]

@oblau: This PR has been marked as verified by oblau.

Details

In response to this:

/verified by oblau

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.