Skip to content

OCPBUGS-80958: Kube apiserver node replace - #371

Closed
bhperry wants to merge 1 commit into
openshift:masterfrom
bhperry:kube-apiserver-node-replace
Closed

OCPBUGS-80958: Kube apiserver node replace#371
bhperry wants to merge 1 commit into
openshift:masterfrom
bhperry:kube-apiserver-node-replace

Conversation

@bhperry

@bhperry bhperry commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Support new NodeUID status field in NodeStatusApplyConfiguration to allow controllers to record the UID of nodes they observe.

Related PRs:

openshift/api#2821
openshift/library-go#2178
openshift/cluster-kube-apiserver-operator#2199

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 24, 2026

Copy link
Copy Markdown

@bhperry: This pull request references Jira Issue OCPBUGS-80958, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bhperry
bhperry marked this pull request as draft April 24, 2026 15:55
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2026
@openshift-ci
openshift-ci Bot requested review from JoelSpeed and deads2k April 24, 2026 15:56
@openshift-ci

openshift-ci Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhperry
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bhperry

bhperry commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 27, 2026

Copy link
Copy Markdown

@bhperry: This pull request references Jira Issue OCPBUGS-80958, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch 2 times, most recently from 784a419 to 439d308 Compare April 30, 2026 17:16
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch from 439d308 to 1a282f3 Compare June 16, 2026 15:17
@bhperry bhperry mentioned this pull request Jun 16, 2026
Merged
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch 4 times, most recently from d6ed281 to b5b680e Compare July 1, 2026 17:25
This was referenced Jul 6, 2026
Open
Open
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch 2 times, most recently from 07f92d6 to 5f1c3f0 Compare July 8, 2026 14:58
@bhperry
bhperry marked this pull request as ready for review July 8, 2026 20:56
@bhperry bhperry changed the title WIP: OCPBUGS-80958: Kube apiserver node replace OCPBUGS-80958: Kube apiserver node replace Jul 8, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-ci
openshift-ci Bot requested a review from bertinatto July 8, 2026 20:57
@bhperry

bhperry commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/hold

depends on api change

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2026
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch 4 times, most recently from 7696020 to c633580 Compare July 16, 2026 15:15
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch from c633580 to 808ba24 Compare July 21, 2026 14:40
JoelSpeed
JoelSpeed reviewed Jul 22, 2026
View reviewed changes
Comment thread go.mod Outdated
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch from 808ba24 to 7d6cc46 Compare July 27, 2026 15:16
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2026
@bhperry
bhperry force-pushed the kube-apiserver-node-replace branch from 7d6cc46 to 52329b8 Compare July 27, 2026 15:27
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2026
@bhperry

bhperry commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/hold cancel

@bhperry

bhperry commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/verified by me

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 27, 2026

Copy link
Copy Markdown

@bhperry: This PR has been marked as verified by me.

Details

In response to this:

/verified by me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@bhperry: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot

openshift-ci-robot commented Jul 27, 2026

Copy link
Copy Markdown

@bhperry: This pull request references Jira Issue OCPBUGS-80958, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Support new NodeUID status field in NodeStatusApplyConfiguration to allow controllers to record the UID of nodes they observe.

Related PRs:

openshift/api#2821
openshift/library-go#2178
openshift/cluster-kube-apiserver-operator#2199

TODO:

  • Remove go.mod replace once the api PR merges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bhperry

bhperry commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Closing, api changes pulled into master by a different PR.

@bhperry bhperry closed this Jul 28, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 28, 2026

Copy link
Copy Markdown

@bhperry: This pull request references Jira Issue OCPBUGS-80958. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Support new NodeUID status field in NodeStatusApplyConfiguration to allow controllers to record the UID of nodes they observe.

Related PRs:

openshift/api#2821
openshift/library-go#2178
openshift/cluster-kube-apiserver-operator#2199

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bhperry
bhperry deleted the kube-apiserver-node-replace branch July 28, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k
@bertinatto bertinatto Awaiting requested review from bertinatto
1 more reviewer
@JoelSpeed JoelSpeed JoelSpeed left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhperry @openshift-ci-robot @JoelSpeed