[release-4.22] SPLAT-2865: Add vSphere multi vCenter Day 2 by vr4manta · Pull Request #2969 · openshift/api

vr4manta · 2026-08-04T14:24:37Z

Changes

Created new VSphereMultiVCenterDay2 feature gate
Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

openshift-merge-bot · 2026-08-04T14:24:39Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-04T14:24:41Z

@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue.

Details

In response to this:

SPLAT-2865

Changes

Created new VSphereMultiVCenterDay2 feature gate

Added logic to handle day 2 processing of adding / removing vCenters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-04T14:24:43Z

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2026-08-04T14:24:43Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-04T14:24:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6886fc9e-7eed-460e-b253-2d7609c1d5b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

vr4manta · 2026-08-04T14:25:29Z

/test all

qodo-for-rh-openshift · 2026-08-04T14:31:02Z

PR-Agent: could not find a component named all in a supported language in this PR.

vr4manta · 2026-08-06T19:04:24Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-08-06T19:04:43Z

@vr4manta: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

…e, and other review suggestions.

…2 feature gate to TP""

vr4manta · 2026-09-04T11:59:41Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-09-04T11:59:51Z

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d51e210-a858-11f1-8021-2ae6565127f3-0

vr4manta · 2026-09-04T15:19:11Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-09-04T15:19:20Z

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb9027b0-a873-11f1-9d70-57471176ae00-0

vr4manta · 2026-09-08T11:30:44Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-09-08T11:30:56Z

@vr4manta: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb3dc9d0-ab78-11f1-89a9-861801216705-0

vr4manta · 2026-09-08T13:13:22Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-09-08T13:14:01Z

@vr4manta: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1248eda0-ab87-11f1-8f62-cd05816d43e3-0

vr4manta · 2026-09-08T14:22:45Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

openshift-ci · 2026-09-08T14:23:21Z

@vr4manta: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0

everettraven

/lgtm

everettraven · 2026-09-08T16:50:59Z

Known breaking validation changes here and we have added sufficient ratcheting validation testing.

/override ci/prow/verify-crdify

openshift-merge-bot · 2026-09-08T16:51:16Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci · 2026-09-08T16:51:20Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crdify

Details

In response to this:

Known breaking validation changes here and we have added sufficient ratcheting validation testing.

/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-09-08T16:51:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vr4manta · 2026-09-09T11:14:43Z

The payload job ran the 2 serial tests and they were green. 1of2 ran 4 of the OTE FG tests. 2of2 ran 3 of the OTE FG tests.

/verified by payload-job-with-prs

openshift-ci-robot · 2026-09-09T11:14:58Z

@vr4manta: This PR has been marked as verified by payload-job-with-prs.

Details

In response to this:

The payload job ran the 2 serial tests and they were green. 1of2 ran 4 of the OTE FG tests. 2of2 ran 3 of the OTE FG tests.

/verified by payload-job-with-prs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vr4manta · 2026-09-09T11:26:31Z

/retest

everettraven · 2026-09-09T12:32:01Z

/label backport-risk-assessed
/label jira/valid-bug

openshift-merge-bot · 2026-09-09T13:09:41Z

/retest-required

Remaining retests: 0 against base HEAD 42fb550 and 2 for PR HEAD 7aef34c in total

vr4manta · 2026-09-09T15:36:08Z

/retest

openshift-ci · 2026-09-09T18:59:45Z

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	`4f1fc2a`	link	true	`/test verify-hypershift-integration`
ci/prow/e2e-aws-ovn-hypershift	`7aef34c`	link	true	`/test e2e-aws-ovn-hypershift`
ci/prow/e2e-azure	`7aef34c`	link	true	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vr4manta · 2026-09-09T19:36:00Z

/retest

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 4, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2026

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 4, 2026

vr4manta marked this pull request as ready for review September 3, 2026 13:13

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2026

openshift-ci Bot requested review from everettraven and yuqi-zhang September 3, 2026 13:14

vr4manta and others added 9 commits September 3, 2026 10:21

Added vSphere Day 2 logic to CRDs

fbb40e9

Added vSphere Day 2 tests

515ab1d

Modified parent logic to not check size, but only changes in existenc…

1403bb1

…e, and other review suggestions.

Added some ratcheting tests to cover change in min size of vCenters

3af80f2

Updated vcenter logic to make sure no server switching occurs

9e60c03

Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay…

e7a1abc

…2 feature gate to TP""

Added vSphere failure domain to vcenter check

e5789c7

Added vSphere failure domain to vcenter ratcheting tests

d8c1b29

updates after rebase

7aef34c

openshift-ci Bot assigned everettraven Sep 3, 2026

everettraven approved these changes Sep 8, 2026

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2026

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 9, 2026

openshift-ci Bot assigned gangwgr Sep 9, 2026

Uh oh!

Conversation

vr4manta commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

vr4manta commented Aug 4, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vr4manta commented Aug 6, 2026

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

vr4manta commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

vr4manta commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

vr4manta commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

vr4manta commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

vr4manta commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

everettraven commented Sep 8, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

vr4manta commented Sep 9, 2026

Uh oh!

openshift-ci-robot commented Sep 9, 2026

Uh oh!

vr4manta commented Sep 9, 2026

Uh oh!

everettraven commented Sep 9, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 9, 2026

Uh oh!

vr4manta commented Sep 9, 2026

Uh oh!

openshift-ci Bot commented Sep 9, 2026

Uh oh!

vr4manta commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

vr4manta commented Aug 4, 2026 •

edited

Loading

openshift-ci-robot commented Aug 4, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Aug 4, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Aug 4, 2026 •

edited

Loading