Fix unitTest task not running the test source set - #2073
Closed
loggk wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Logan Kennedy <kennedylogan22@gmail.com>
loggk
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
July 31, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
./gradlew unitTestruns 1 test class instead of 170 — the tests undersrc/test/javaare never executed, locally or in CI.unitTestis created withtask<Test>("unitTest"), which has notestClassesDirsorclasspath. The only place they get populated is the JDK-21 block, which appends to that empty base:So the task resolves to the
java21source set alone. This is a regression from #968, where those two lines were moved offtasks.test— whosetestClassesDirsthe java plugin populates, making+=correct — and ontounitTest/integrationTest, which have no base.Changes
Set
testClassesDirsandclasspathonunitTestfrom thetestsource set, so the JDK-21 block appends to it rather than defines it../gradlew :java-client:unitTeston JDK 21 (Temurin 21.0.11), counted fromjava-client/build/test-results/unitTest/:All 426 pass, so no other change is needed to re-enable them.
RequestOptionsTestfromsrc/test/java11still runs, and theexcludeTestsMatchingfilter still keepsintegTestclasses out.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.