Huge amount of fixes in ::: templates ::: - #1286
Merged
Merged
Conversation
NexiusTailer
requested review from
a team,
NermanLegacy,
Woscript,
daddyDOT,
itsneufox,
midosvt and
ulasbayraktar
as code owners
September 27, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the ugly things existing now is this: https://imgur.com/5k2QeF1
This example combined several issues which this PR fixes everywhere they were found:
tiptemplate because of missed ending:::closer; surprisingly it's somehow rendered, but completely incorrect, nesting the next different boxtiptemplate box is actually wrong for the first statement, it's just a noteThe last problem comes from the fact that when it firstly ported from SA-MP wiki mirrors, most of the notes or warnings became tips for some reason. People fixed some specific cases during all this time, but general wrong pattern is still visible.
So the first thing which was done is comparing all the pages containing templates with blast.hk, UG-MP wiki and other mirrors to catch the most of mismatches automatically. Then I applied these rules over the already tweaked template types to fix the rest which could be still wrong (in case if they were wrong on the old wiki page):
warningnotetipThen I fixed all the found templates which were broken in different ways:
:::lines, as this produces render errorsAnd finally, merged two or more template boxes with same type statements which are going one by one, into a single one.
There were also some cases of wrongly merged statements into a single template type box before, so they were splitted into a few different.
So, now template box types are semantically correct to its content and mostly consistent with the original source from where they were initially ported