Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Service Options group box to the Stream settings page that generically renders a service's own properties, so a plugin no longer needs frontend changes to expose its settings.
When the selected entry is a plugin-provided service type,
OBSBasicSettings_Stream.cppnow builds anOBSPropertiesViewfrom that service'sget_propertiesand shows it below the existing Server / Stream Key rows. The following new methods achieve this:LoadServicePropertiesViewcreates the view, but only for a custom service type that actually has at least one custom property. Otherwise the group box stays hidden.ClearServicePropertiesViewtears the view down and hides the group box when the selection changes.SeedServicePropertiesSettingsseeds the view fromobs_service_defaults, then overlays the currently configured service's saved settings when the selected type matches it, so the user sees their existing values.MergeServicePropertiesmerges the view's values back into the settings object on save.Motivation and Context
obsproject#12991 makes a plugin's service appear in the services dropdown, but the Stream page could still only configure Server and Stream Key. Any service with settings of its own had nowhere to put them in the UI. That left plugins with the same problem obsproject#12991 solves for discovery: edit
OBSBasicSettings_Stream.cppto hardcode new fields.How Has This Been Tested?
Tested on macOS Tahoe.
rtmp_commonand other similar services.Types of changes
Checklist:
This change is