Remove type parameter - #1305
Open
PGijsbers wants to merge 2 commits into
Open
Conversation
The arguments aren't used directly anyway. Since the type is not used, and before PHP 8 superfluous function arguments get ignored, making it safe to remove.
omosola
self-requested a review
August 4, 2026 16:03
omosola
marked this pull request as ready for review
August 4, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1304.
Allows arbitrary number of arguments to v1 functions, as this function is called by Code Igniter and the values passed depends on how the function is accessed. The values are never actually used, so we could also omit them, but that would raise errors if we were to ever update to PHP 8+.
When deployed with the
servicesdocker compose making a requestcurl http://localhost:8080/data/v1used to write an errorSeverity: error --> Exception: Too few arguments to function Data::v1(), 0 passed in /var/www/openml/system/core/CodeIgniter.php on line 532 and exactly 1 expected /var/www/openml/openml_OS/controllers/Data.php 42and return XML about an PHP error being encountered, and now instead returns an error to the client with "Function not valid".