Fix missing ENDF/B-VIII.1 TSL UinUO-*P.endf - #105
Open
yrrepy wants to merge 2 commits into
Open
Conversation
Add update_zsymam function calls for thermal scattering files: tsl-UinUO2-5P.endf tsl-UinUO2-10P.endf tsl-UinUO2-100P.endf otherwise a naming collision occurs and these are not produced (only tsl-UinUO2.endf is)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the three uranium-in-UO₂ S(α,β) evaluations from ENDF/B-VIII.1 that are missed in processing:
tsl-UinUO2-5P.endftsl-UinUO2-10P.endftsl-UinUO2-100P.endfThese produce:
c_U_in_UO2_5p.h5c_U_in_UO2_10p.h5c_U_in_UO2_100p.h5The corresponding oxygen-in-UO₂ evaluations are already processed by the existing script.
These three source evaluations use the same
ZSYMAMidentifier,U(UO2), as each other and as the natural-uranium evaluation. This causes the processed tables to receive conflicting names. For ENDF/B-VIII.1 processing, this PR changes only theZSYMAMmetadata field, assigning the unique identifiersUUO2-5P,UUO2-10P, andUUO2-100Pbefore passing the evaluations to NJOY.Validation
openmc.data.ThermalScattering.from_hdf5().Other: Processing Nuclide Choice
The below uranium TSL all use U238 (left as-is currently), LANL ENDF81SaB uses U235.
From my interrogation, this mostly affects the NJOY generated energy-grid that makes its way to the TSL file. Causing very small differences.
The AWR is also affected, but it doesn't seem that it is used by or from the TSL file.