8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit - #752
Open
rm-gh-8 wants to merge 1 commit into
Open
8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit#752rm-gh-8 wants to merge 1 commit into
rm-gh-8 wants to merge 1 commit into
Conversation
rm-gh-8
marked this pull request as ready for review
August 25, 2026 13:02
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
Bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
Bot
added
backport
5 tasks
Contributor
|
This is a duplicate of #756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8380223: Refactor test/jdk/sun/util/resources TestNG tests to JUnit.
This PR migrates CLDR and time zone tests from TestNG to JUnit.
This PR is not clean because it skips JDK-8354548 and JDK-8260555 for Bug8139107.java, which introduce a large dependency graph and only introduces minor changes to the test (timeout and additional try/catch enclosure).
This is a prerequisite for JDK-8381379, which is for parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/util/resources
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/752/head:pull/752$ git checkout pull/752Update a local copy of the PR:
$ git checkout pull/752$ git pull https://git.openjdk.org/jdk25u-dev.git pull/752/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 752View PR using the GUI difftool:
$ git pr show -t 752Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/752.diff
Using Webrev
Link to Webrev Comment