Skip to content

feat: remove enterprise enrollment imports and adds CourseEnrollmentViewStarted filter#38106

Merged
kiram15 merged 1 commit into
masterfrom
pwnage101/ENT-11570
Jul 22, 2026
Merged

feat: remove enterprise enrollment imports and adds CourseEnrollmentViewStarted filter#38106
kiram15 merged 1 commit into
masterfrom
pwnage101/ENT-11570

Conversation

@pwnage101

@pwnage101 pwnage101 commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes those enterprise imports and the conditional block from the enrollment view, then runs the CourseModeCheckoutStarted filter to handle the enterprise-specific enrollment logic separately and outside of edx-platform. This is part of an ongoing initiative to leverage openedx-filters to allow enterprise to customize logic and remove it from edx-platform code.

ENT-11570

Supporting information

This is the openedx/openedx-filters#363
This is openedx/edx-enterprise#2553
And this is the corresponding https://github.com/openedx/openedx-platform/pull/38106

Testing instructions

Testing instructions in the openedx/edx-enterprise#2553.

Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/django_comment_client/base/views.py Fixed
Comment thread lms/djangoapps/discussion/rest_api/tests/utils.py Fixed
Comment thread openedx/core/djangoapps/user_api/accounts/views.py Fixed
Comment thread cms/djangoapps/contentstore/rest_api/v1/views/unit_handler.py Fixed
Comment thread cms/djangoapps/modulestore_migrator/rest_api/v1/views.py Fixed
@kiram15
kiram15 marked this pull request as draft July 17, 2026 20:18
@kiram15
kiram15 force-pushed the pwnage101/ENT-11570 branch 3 times, most recently from 9fadbc6 to 8530586 Compare July 21, 2026 22:32
@kiram15
kiram15 force-pushed the pwnage101/ENT-11570 branch from 8530586 to 85f323f Compare July 21, 2026 22:49
@kiram15
kiram15 marked this pull request as ready for review July 22, 2026 16:06
@kiram15 kiram15 changed the title feat: remove enterprise enrollment API imports and conditional block from enrollments/views.py feat: remove enterprise enrollment imports and adds CourseEnrollmentViewStarted filter Jul 22, 2026

@pwnage101 pwnage101 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

@kiram15
kiram15 merged commit ce81ef0 into master Jul 22, 2026
46 of 47 checks passed
@kiram15
kiram15 deleted the pwnage101/ENT-11570 branch July 22, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise An enterprise-related change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants