Open the system picker directly - #526
Merged
Merged
Conversation
andiwand
force-pushed
the
landing/03-recents-list
branch
from
July 27, 2026 20:40
41dcdf7 to
b3c2675
Compare
andiwand
force-pushed
the
landing/04-direct-picker
branch
from
July 27, 2026 20:40
2a58ee6 to
9ace181
Compare
andiwand
force-pushed
the
landing/03-recents-list
branch
from
July 27, 2026 22:01
b3c2675 to
2174369
Compare
andiwand
force-pushed
the
landing/04-direct-picker
branch
from
July 27, 2026 22:01
9ace181 to
870bcce
Compare
andiwand
force-pushed
the
landing/03-recents-list
branch
from
July 28, 2026 07:43
2174369 to
4110d98
Compare
andiwand
force-pushed
the
landing/04-direct-picker
branch
from
July 28, 2026 07:43
870bcce to
303e718
Compare
andiwand
force-pushed
the
landing/03-recents-list
branch
from
July 28, 2026 17:37
4110d98 to
3b8560f
Compare
findDocument queried every activity answering ACTION_OPEN_DOCUMENT and raised an "Open document via:" dialog to choose between them, before the picker it was going to launch anyway. That is a tap that buys nothing: the system picker already browses Drive, Downloads, a usb stick and every installed file manager, and it is the ui people know. Its last row used to be the recently opened documents, which is now the landing screen itself, so the dialog has nothing left that is its own. The <queries> entries stay. They were there for queryIntentActivities, but removing package visibility is exactly the kind of change that breaks on one OEM and nowhere else. MainActivityTests drove the picker through the dialog, so it loses that step; the intent stubbing is untouched, because Espresso-Intents intercepts at execStartActivity, below ActivityResultLauncher. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TiSZ4FeptMUsFjAuCewzQZ
andiwand
force-pushed
the
landing/04-direct-picker
branch
from
July 28, 2026 17:46
303e718 to
4135a0e
Compare
andiwand
marked this pull request as ready for review
July 28, 2026 17:46
andiwand
added a commit
that referenced
this pull request
Jul 28, 2026
findDocument queried every activity answering ACTION_OPEN_DOCUMENT and raised an "Open document via:" dialog to choose between them, before the picker it was going to launch anyway. That is a tap that buys nothing: the system picker already browses Drive, Downloads, a usb stick and every installed file manager, and it is the ui people know. Its last row used to be the recently opened documents, which is now the landing screen itself, so the dialog has nothing left that is its own. The <queries> entries stay. They were there for queryIntentActivities, but removing package visibility is exactly the kind of change that breaks on one OEM and nowhere else. MainActivityTests drove the picker through the dialog, so it loses that step; the intent stubbing is untouched, because Espresso-Intents intercepts at execStartActivity, below ActivityResultLauncher. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Fourth of six, stacked. Base:
landing/03-recents-list(#525). Small and isolated.findDocumentqueried every activity answeringACTION_OPEN_DOCUMENTand raised an "Open document via:" dialog to choose between them — before launching the picker it was going to launch anyway. That tap buys nothing: the system picker already browses Drive, Downloads, a usb stick and every installed file manager, and it is the UI people know.Its last row used to be the recently opened documents, which is the landing screen itself as of the previous PR, so the dialog has nothing of its own left.
The
<queries>entries stay. They were there forqueryIntentActivities, but removing package visibility is exactly the kind of change that breaks on one OEM and nowhere else.MainActivityTestsdrove the picker through that dialog, so it loses the step. The intent stubbing is untouched — Espresso-Intents intercepts atexecStartActivity, belowActivityResultLauncher, so it still matches with the component unset.Verification
18 instrumented tests green, including
testODT,testPDFandtestPasswordProtectedODT, which all go through the changed helper.