Repository navigation
fix: honor HTML output paths and media resource locations - #1180
Merged
Merged
Conversation
andiwand
force-pushed
the
review/spreadsheet-content-limits
branch
from
October 6, 2026 20:20
b6221a9 to
35b89a5
Compare
andiwand
force-pushed
the
review/html-output-paths
branch
from
October 6, 2026 20:29
76dd248 to
75527dd
Compare
andiwand
marked this pull request as ready for review
October 6, 2026 20:30
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
The check in media_file.cpp came in with #1180, after this change was written, so it still tested the optional location implicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
* refactor: make optional presence checks explicit * refactor: make the media location check explicit The check in media_file.cpp came in with #1180, after this change was written, so it still tested the optional location implicitly. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Custom media locators emitted URLs that HtmlService could not serve, document views ignored their configured output filename, and Python browser URLs broke on URL-special path characters. Use the located media resource for routing, honor the configured document name, and construct escaped absolute file URLs. Colliding media paths embed safely; named in-memory WebM files keep their playable MIME type.
Validation: html.* and media_file.* pass in the integrated stack. Python CLI compilation and an isolated mocked browser check with Unicode/#/? paths passed. Regression coverage stays in the renderer rather than repeating it across bindings.