Repository navigation
fix: calculate spreadsheet content within preview limits - #1179
Merged
Merged
Conversation
Counting only cells with content cut off empty cells that still draw: Ordnerruecken.xlsx lost the row whose bottom borders close its spine boxes. An empty cell now counts where its style has a border or a visible fill, as the declared dimension covered it before. A check of every changed corpus page finds no trimmed cell with a border or fill. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/spreadsheet-content-limits
branch
from
October 6, 2026 20:20
b6221a9 to
35b89a5
Compare
andiwand
marked this pull request as ready for review
October 6, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
ODS previews dropped populated cells exactly at the requested bounds and repeated runs crossing them. XLSX ignored the window and trusted declared dimensions. Calculate content from sparse indexed cells, clip repeated and merged spans, and exclude cells outside the window. An empty XLSX cell still counts where its border or fill draws something. Reusing the ODF index removes a second cursor traversal.
Validation: OdfSheet*.* and OoxmlSpreadsheet*.* pass in the integrated stack, including four focused boundary/merge regressions. HTML tests also pass. Attribute-only ODF cells retain their existing treatment.
The rendered output changes for 13 public and 15 private spreadsheet pages, so the reference output needs a regeneration after this merges. ODS pages only gain the populated cells at the window edge. XLSX pages drop empty rows and columns after the content; their only lost text is row numbers and column letters, and none of the trimmed cells has a border or fill.