Repository navigation
test: share SFNT fixtures and consolidate reencode checks - #1062
Merged
Merged
Conversation
andiwand
force-pushed
the
review/43-cff-builder
branch
from
October 5, 2026 13:05
772a392 to
2db849a
Compare
The other test utilities, like type1_test_util.hpp, are included by their path below the library headers, not by a relative quoted path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/44-font-test-fixtures
branch
from
October 5, 2026 13:20
5b5ca59 to
d07b544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Share raw SFNT fixture builders across the font reader, writer, public font API and PDF font tests. The fixtures remain independent of production serialization, so reader checks still catch writer mistakes.
Combine two pairs of re-encoding tests while retaining assertions before and after serialization. This removes 217 lines and two overlapping tests without reducing the checked behavior.
Validation: rebuilt
odr_test; all 84 targeted SFNT, font API, PDF font, CFF and Type1 tests passed.Test-only change.