Skip to content

chore: added cosign to list in common.mk - #28

Merged
rebEllieous merged 1 commit into
mainfrom
feature/687-signing-render-artifacts
Aug 27, 2026
Merged

chore: added cosign to list in common.mk#28
rebEllieous merged 1 commit into
mainfrom
feature/687-signing-render-artifacts

Conversation

@rebEllieous

@rebEllieous rebEllieous commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What

added cosign to tool list

Summary by CodeRabbit

  • Chores
    • Added Cosign to the configured Go-installed tooling.
    • Removed a duplicate OpenAPI generator configuration entry.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9da618e9-6b38-47fd-94c5-0a7929fe2d02

📥 Commits

Reviewing files that changed from the base of the PR and between ee5da7d and cccbb14.

📒 Files selected for processing (1)
  • common.mk

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Tool configuration

Layer / File(s) Summary
Update tool variables
common.mk
Adds the COSIGN tool path and removes the duplicate OPENAPI_GEN declaration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cccbb

This localized change adds cosign to the common tool list and presents no actionable merge-blocking risk beyond normal checks and review.

Suggested reviewers: olzemal

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change but includes only the What section. It omits testing details, reviewer notes, checklist status, and the issue reference. Complete the required pull request template. Add the issue reference, testing performed, applicable reviewer notes, and checklist responses. Remove sections only when they are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding cosign to common.mk tool configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/687-signing-render-artifacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olzemal olzemal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

This could also be added to the flake packages. Maybe we should discuss what our preference is at some point.

@rebEllieous
rebEllieous merged commit d984ba7 into main Aug 27, 2026
7 checks passed
@rebEllieous
rebEllieous deleted the feature/687-signing-render-artifacts branch August 27, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Renderer Signing

3 participants