test: remove direct testify dependency - #155
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for picking this up @PozziTiv4ik. If signing isn't something you are currently able to setup that is no problem at all - just close the PR and the issue can be assigned to someone else. |
Summary
github.com/stretchr/testifyas a direct dependency and tidy the module filesCloses #143
Testing
go mod verifygo build ./...go vet ./...go test ./... -run '^$'go test ./api/... ./internal/fieldpath ./internal/kcp ./internal/webhookEnvironment limitation
go test ./internal/controllerreaches the new assertion but cannot complete on Windows because envtest expects the kcp server binary and kcp does not publish that server for Windows. The repository CI runs the kcp test matrix on Ubuntu.