Skip to content

test: remove direct testify dependency - #155

Open
PozziTiv4ik wants to merge 1 commit into
opendefensecloud:mainfrom
PozziTiv4ik:fix/143-remove-testify
Open

test: remove direct testify dependency#155
PozziTiv4ik wants to merge 1 commit into
opendefensecloud:mainfrom
PozziTiv4ik:fix/143-remove-testify

Conversation

@PozziTiv4ik

Copy link
Copy Markdown

Summary

  • replace the suite startup assertion with the standalone Gomega API already used by the test suite
  • remove github.com/stretchr/testify as a direct dependency and tidy the module files
  • retain testify only as an indirect dependency required by Kubernetes test packages

Closes #143

Testing

  • go mod verify
  • go build ./...
  • go vet ./...
  • go test ./... -run '^$'
  • go test ./api/... ./internal/fieldpath ./internal/kcp ./internal/webhook

Environment limitation

go test ./internal/controller reaches the new assertion but cannot complete on Windows because envtest expects the kcp server binary and kcp does not publish that server for Windows. The repository CI runs the kcp test matrix on Ubuntu.

@PozziTiv4ik
PozziTiv4ik requested a review from a team August 20, 2026 19:46
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 920c94ff-a97a-4d18-8f84-d8ad1e535531


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BergCyrill

Copy link
Copy Markdown
Contributor

Thank you for picking this up @PozziTiv4ik.
There is a blocker for now: This repository requires signed commits on main. We haven't written it down anywhere (but it should be visible in the PR) - that's on us and it will go into a contributing guideline shortly. We will also move to an assigned-issue-contribution approach then.
For now please amend your commit with a valid signing key.

If signing isn't something you are currently able to setup that is no problem at all - just close the PR and the issue can be assigned to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap testify for gomega standalone assertion

2 participants