Repository navigation
ci(cla): an allowlisted commit needs an allowlisted author and committer and a verified signature - #10
Merged
Conversation
…ter and a verified signature A signature proves only the committer, so an outside contributor could name the maintainer as author and sign with their own key and skip the CLA. The scope step now accepts such a commit only when author and committer are both allowlisted and the signature is verified. Steps select pull request events by payload. cla-scope.test.sh runs the step against recorded commit lists; cla-test.yml runs it when the workflow changes.
0xmanhnv
added a commit
that referenced
this pull request
Oct 19, 2026
…ter and a verified signature (#10) A signature proves only the committer, so an outside contributor could name the maintainer as author and sign with their own key and skip the CLA. The scope step now accepts such a commit only when author and committer are both allowlisted and the signature is verified. Steps select pull request events by payload. cla-scope.test.sh runs the step against recorded commit lists; cla-test.yml runs it when the workflow changes. Co-authored-by: Nguyen Manh <manhnv@openctem.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the CLA check that was merged here. A security review found a bypass in its "Decide who must sign" step, fixed here.
The hole: in a pull request opened by an outside account, a commit linked to an allowlisted account (the maintainer or a bot) was accepted when its signature was verified. A signature proves only the committer, and the author e-mail is free text, so a contributor could set the maintainer's e-mail as author, sign with their own key, and skip the CLA.
The fix: the step judges each commit by the account the CLA action uses (author, else committer). If that is an allowlisted account, the commit counts only when the author AND the committer are both allowlisted AND the signature is verified; otherwise the check fails and names the commit. Steps now select pull request events by payload (
github.event.pull_request), not by event name.Tests:
.github/scripts/cla-scope.test.shextracts the step fromcla.ymland runs it against 10 recorded commit lists (maintainer, bot and outside pull requests; forged author, forged committer, contributor-signed). The previous logic fails 2 of them.cla-test.ymlruns the test on pull requests and pushes that change the workflow or the test (read-only token,persist-credentials: false).Also documented in the workflow header: keep
clarequired on pull requests; in the merge queue it passes at once. The archived upstream action's replacement is planned in openctemio/openctem#2299.Security: same model as before. The check runs in the base context and never checks out or runs pull request code; the test workflow runs the pull request's own copy on
pull_requestwithcontents: readonly. Secret still needed: org secretCLA_SIGNATURES_TOKEN(fine-grained PAT, resource owneropenctemio, repository access onlyopenctemio/cla-signatures, Contents read/write).