fix(graph): expose allowedValues on driveItem children - #3476
Open
dschmidt wants to merge 2 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 93.75% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 93.75% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (d6c6b6f) 88333 20805 23.55% Head commit (b8eb8f8) 88310 (-23) 20792 (-13) 23.54% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3476) 16 15 93.75% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
fix/graph-children-allowed-values
branch
3 times, most recently
from
September 7, 2026 06:33
5af6b43 to
d1ef47d
Compare
dschmidt
marked this pull request as ready for review
September 7, 2026 06:36
dschmidt
force-pushed
the
fix/graph-children-allowed-values
branch
from
September 7, 2026 10:55
d1ef47d to
7dda440
Compare
GetRootDriveChildren and GetDriveItem fill @libre.graph.permissions.actions.allowedValues on $select, the shared children listing did not, so every child in /children and $expand=children came back without its allowed actions and clients treated the listing as read only. Add a setDriveItem(s)AllowedValues helper pair, matching the thumbnails and shareTypes shape, and apply it in the listing. GetRootDriveChildren now delegates to the shared children listing instead of repeating its ListContainer + format + shareTypes tail; permission denied on the root listing answers 404 like the item children endpoint (the TODO that sat there), not 403.
dschmidt
force-pushed
the
fix/graph-children-allowed-values
branch
from
September 7, 2026 14:52
7dda440 to
b8eb8f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$select=@libre.graph.permissions.actions.allowedValuesis filled byGetRootDriveChildrenandGetDriveItem, but not by the shared children listing behind/childrenand$expand=children. Every child came back without its allowed actions, so a client that derives permissions from them treats the whole listing as read only (no download, rename, delete).It went unnoticed because the single-item stat always carried them and
$expand=childrenis new.listDriveItemChildrenfills allowedValues now, via asetDriveItem(s)AllowedValueshelper pair that mirrors the thumbnails and shareTypes shape; the CS3-to-libregraph action mapping lives in one place.GetRootDriveChildrendelegates tolistDriveItemChildreninstead of repeating its ListContainer + format + shareTypes tail, so root children gain the same annotations from one code path.Behaviour change: permission denied on
/me/drive/root/childrennow answers 404 instead of 403, matching the item children endpoint and theTODOthat sat on that line. The spec documents only200plus a genericdefaulterror for both endpoints, so no spec change is needed.