Conversation
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Android file-opening flows to use the native resolver, allowing users to set default apps.
Changes:
- Removes forced chooser dialogs.
- Applies direct intent launching across file-opening paths.
- Preserves no-app error handling.
File summaries
| File | Description |
|---|---|
opencloudApp/src/main/java/eu/opencloud/android/ui/helpers/FileOperationsHelper.java |
Opens files using direct intents. |
opencloudApp/src/main/java/eu/opencloud/android/extensions/ActivityExt.kt |
Applies native resolver behavior to file-opening flows. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now there is a proper android app picker where you can actually select to always open the file type with a certain app instead of ALWAYS seeing the app picker.