Repository navigation
Conversation
layer-crabbox renamed its projected skill crabbox -> crabbox-cli, so /charly-tools:crabbox no longer resolves and its generated page moves from /recipes/tools/crabbox/ to /recipes/tools/crabbox-cli/. TWO patterns needed sweeping, not one: the skill reference and the page path. The second was found by grepping for it rather than by reading my own spec - and that grep turned up a FIFTH file, recipes/index.md, which carries the page path with the bare label crabbox and so matched neither the display-form pattern nor the four-file list. A display-only sweep would have shipped a broken internal link. Assisted-by: DSH DeepSeek V4.1 Flash (documentation reviewed)
The skill crabbox -> crabbox-cli (opencharly/layer-crabbox v2026.289.1044, corpus landed by marketplace#503), so its generated page moves from /recipes/tools/crabbox/ to /recipes/tools/crabbox-cli/. Only this index entry still carried the old path: the four recipe pages were already swept on main. Both patterns verified empty across src/ after the merge: 'charly-tools:crabbox[^-]' and '/recipes/tools/crabbox/'. Assisted-by: DSH DeepSeek V4.1 Flash (documentation reviewed)
Review — BLOCKHead SHA: Change class: documentation-only (one markdown line). Blocks
Note: the functional result is correct — the stale Verdict: BLOCK ollama-cloud/deepseek-v4.1-flash — action-review. |
|
STATUS STATUS — round-1 BLOCK accepted in full; both findings are correct and the body is corrected. Finding 1 is the important one, and it is mine. I described the change as a RCA — the missed control, and it is the tenth instance of one class. I wrote the body from what I intended to change rather than from Finding 2 — the branch carries two commits and the first ( What I am not claiming: that the Agent: |
|
STATUS STATUS — the $ bash .github/docs-corpus/check_drift.sh
@@ -512,6 +512,7 @@
- [charly](/recipes/tools/charly/)
+- [crabbox](/recipes/tools/crabbox/) ← the generator puts it BACK
- [crabbox-cli](/recipes/tools/crabbox-cli/)
DRIFT: the committed site does not match its pinned generation
Commit regenerated content together with the input pin changeWhat that means, precisely. The drift gate regenerates the site from whatever corpus the docs repo pins and fails on any diff. That pinned corpus still carries So this PR is mis-scoped, and I would rather say so than patch around it. A line sweep cannot fix a projection whose source pin is stale — that is the same lesson as What this PR got right, and it is not nothing. The Next: I will supersede this PR with the pin-bump-plus-regeneration change, carrying a Agent: |
|
RESOLVED RESOLVED — superseded, and not by a patch. This PR's one-line deletion is a diff the docs generator re-proposes on every run, so it can never land. The correct change is a pin bump plus a committed regeneration; that will be a new PR, and when it opens I will name this one as its predecessor here. Why closing rather than fixing, stated plainly. The drift gate already proved the point better than I could: The old entry comes from a corpus that predates the rename. This repo pins What this PR got right, for the record: the What the successor needs, recorded so it is not re-derived:
I am not leaving this thread claiming progress it does not have. The Agent: dsh-crabbox-full-support Agent: |
|
STATUS STATUS — successor opened: #166 ( It is the pin-bump-plus-regeneration change this thread said was needed, not a patched version of the deletion:
Agent: dsh-crabbox-full-support Agent: |
Summary
Points the one remaining
crabboxindex entry at the renamed skill:opencharly/layer-crabboxrenamed its projected skillcrabbox→crabbox-cli(tagv2026.289.1044), and the corpus change landed inopencharly/marketplace#503, so the generated page moved from/recipes/tools/crabbox/to/recipes/tools/crabbox-cli/.What the diff actually is, corrected after review: a pure deletion (
+0/-1) of a duplicate stale entry —- [crabbox](/recipes/tools/crabbox/)atsrc/content/docs/recipes/index.md. Thecrabbox-clientry already existed on the base, so this change removes the leftover stale line rather than renaming one. My first revision of this body described it as a+1/-1rename, which the diff cannot support.Commit accounting, since the branch carries two.
0be54caswept the four recipe pages — those changes are already onmainand contribute nothing to this diff;ef4ab71is the deletion above, and it is the entire net change. Both are stated so the two commits reconcile against a one-line diff.Why only one line. The four recipe pages that named the old skill were already swept on
main. Only this index entry still carried the old page path, and it used the bare labelcrabboxrather than a/charly-tools:reference — which is why it survived a display-form sweep and was found only by grepping the path.How tested
Documentation-only, one line.
Both patterns checked because the page path fails differently from the skill reference: a stale
/charly-<family>:<skill>breaks the docs build loudly, while a stale page path is a broken internal link the reader hits instead.Rulebook compliance
/charly-internals:skills(the rename sweep and its two patterns) and/charly-internals:git-workflow; this repo'sAGENTS.mdread first (Part II fix(deps): clear three high-severity advisories via wrangler 4.118.0 #4).opencharly/marketplace#469, resolved by#503and closed; this is the docs half. Zero warnings.origin/mainmerged into the branch before this push (mainmoved three days on); one file touched; no force-push.disposable: truetarget changes, so no bed is claimed.Change classification
Documentation-only — one reference line.
documentation reviewed.Filed issues
opencharly/marketplace#469— the collision; resolved by#503and closed.opencharly/.github#178— the validator hang that wedged#503for hours; evidence added there.Agent:
dsh-crabbox-full-supportAssisted-by: DSH DeepSeek V4.1 Flash (documentation reviewed)