Show registration modal only when unregistered#1600
Conversation
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1600/2026-05-11_21-10-31/ . |
…in suboptimal cases
75e3a11 to
298d1a8
Compare
|
Now that the GHA issues are done, I made a final change and I think this is ready for re-review @Arnei |
| onClick={() => showAdoptersRegistrationModal()} | ||
| > | ||
| <span className="wide-text">Registration</span> | ||
| <span className="multi-value multi-value-yellow">Unregistered</span> |
There was a problem hiding this comment.
multi-value-yellow does not seem to exist (maybe I removed it in my cleaning frenzy?).
| <ButtonLikeAnchor | ||
| onClick={() => showAdoptersRegistrationModal()} | ||
| > | ||
| <span className="wide-text">Registration</span> |
There was a problem hiding this comment.
The text in the little colored bubbles is now translated. Shouldn't "Registration" be translated too?
| export type RegistrationState = { | ||
| registration: Registration | null, | ||
| latestToU: string, | ||
| isRegistering: boolean, |
There was a problem hiding this comment.
I feel like isRegistering is a bit confusingly named? This is not about being in the process of registering, is it? Maybe canRegister would be clearer?
There was a problem hiding this comment.
I fought with naming here a lot, and I agree that it sucks. This boolean is true if the backend can talk to the main registration server, false otherwise.
What about something like ableToRegister?
…represents whether the registration service can talk to the main registration server.
… the modal will open even if the user has already registered.
340024a to
3247ac4
Compare
2 participants
This PR only shows the registraiton modal when the adopter has not already registered.
This PR contains a few extra bits that haven't been turned on yet - notably the warning bell stuff for when the core can't reach the registration server.This PR now uses the bell if the user is not registered. Notably:
If you haven't registered at all:
If you have registered, but haven't agreed to the latest ToU:
Clicking on either of these notices opens the registration modal.
TODOs:
Make the new strings into translatable strings rather than hardcoding them.Fixed #1516