Skip to content

ci: prepare checks for merge queue - #332

Merged
jbeckwith-oai merged 2 commits into
mainfrom
codex/enable-merge-queue
Aug 3, 2026
Merged

ci: prepare checks for merge queue#332
jbeckwith-oai merged 2 commits into
mainfrom
codex/enable-merge-queue

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

  • trigger the required CI workflow for GitHub merge-group checks
  • allow the aggregate ci / ci-required job to run for queued merge commits

Why

GitHub requires Actions-based required checks to listen for the separate merge_group event. Without this change, enabling the queue would leave queued pull requests waiting for a required check that never reports.

Impact

Once the repository merge queue is enabled, CI will run again when an approved pull request enters the queue, validating it against the latest main and any changes ahead of it in the queue. The Stainless staging artifact path remains unchanged.

Validation

  • YAML parsed successfully
  • git diff --check
  • trigger/job-gate alignment check
  • thermo-nuclear code-quality review (no findings)

Follow-up

After this lands, enable the main ruleset merge queue with squash-only merging, all-green grouping, one PR per merge, five concurrent builds, and a 60-minute check timeout.

Copilot AI review requested due to automatic review settings August 3, 2026 20:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CI workflow so GitHub’s merge queue (merge-group) can trigger the required Actions checks, ensuring queued merge commits report the required status checks instead of waiting indefinitely.

Changes:

  • Add merge_group (checks_requested) as a workflow trigger.
  • Update the workflow job gate to allow CI to run when invoked by the merge_group event.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review August 3, 2026 20:42
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 3, 2026 20:42
@openai-sdks

openai-sdks Bot commented Aug 3, 2026

Copy link
Copy Markdown

OkTest Summary

237/237 SDK tests passed in 9.149s for Ruby SDK PR #332.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 177ms
tests/chat-completions-create.test.ts ✅ Passed 257ms
tests/chat-completions-stream.test.ts ✅ Passed 138ms
tests/files-content-binary.test.ts ✅ Passed 288ms
tests/files-create-multipart.test.ts ✅ Passed 305ms
tests/files-list-pagination.test.ts ✅ Passed 195ms
tests/initialize-config.test.ts ✅ Passed 181ms
tests/instance-isolation.test.ts ✅ Passed 271ms
tests/models-list.test.ts ✅ Passed 250ms
tests/responses-background-lifecycle.test.ts ✅ Passed 246ms
tests/responses-body-method-errors.test.ts ✅ Passed 493ms
tests/responses-cancel-timeout.test.ts ✅ Passed 224ms
tests/responses-cancel.test.ts ✅ Passed 254ms
tests/responses-compact-retries.test.ts ✅ Passed 280ms
tests/responses-compact.test.ts ✅ Passed 274ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 157ms
tests/responses-create-advanced.test.ts ✅ Passed 209ms
tests/responses-create-disconnect.test.ts ✅ Passed 166ms
tests/responses-create-errors.test.ts ✅ Passed 284ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 150ms
tests/responses-create-retries.test.ts ✅ Passed 282ms
tests/responses-create-stream-failures.test.ts ✅ Passed 154ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 225ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.057s
tests/responses-create-stream.test.ts ✅ Passed 112ms
tests/responses-create-terminal-states.test.ts ✅ Passed 274ms
tests/responses-create-timeout.test.ts ✅ Passed 233ms
tests/responses-create.test.ts ✅ Passed 319ms
tests/responses-delete.test.ts ✅ Passed 293ms
tests/responses-input-items-errors.test.ts ✅ Passed 207ms
tests/responses-input-items-list.test.ts ✅ Passed 205ms
tests/responses-input-items-options.test.ts ✅ Passed 281ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 265ms
tests/responses-input-tokens-count.test.ts ✅ Passed 250ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.244s
tests/responses-not-found-errors.test.ts ✅ Passed 354ms
tests/responses-parse.test.ts ✅ Passed 206ms
tests/responses-retrieve-retries.test.ts ✅ Passed 252ms
tests/responses-retrieve.test.ts ✅ Passed 264ms
tests/responses-stored-method-errors.test.ts ✅ Passed 727ms
tests/retry-behavior.test.ts ✅ Passed 2.004s
tests/sdk-error-shape.test.ts ✅ Passed 402ms

View OkTest run #30852021672

SDK merge (c13b6e19e3f9) · head (c4a1f3215fe6) · base (a602a553282c) · OkTest (91635c6a2723)

@jbeckwith-oai
jbeckwith-oai enabled auto-merge (squash) August 3, 2026 20:45

@HAYDEN-OAI HAYDEN-OAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One substantive merge-queue correctness issue identified: queue-branch push runs can cancel the only workflow run that reports the required merge-group check. Details and remediation are attached inline. The required-check aggregation, current main protections, and existing CodeQL PR/post-merge behavior otherwise match the stated rollout.

Comment thread .github/workflows/ci.yml
Copilot AI review requested due to automatic review settings August 3, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/ci.yml

@HAYDEN-OAI HAYDEN-OAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at c4a1f3215fe675b6626d69a194fa5c888e8b4f51. The new !gh-readonly-queue/** exclusion follows the positive ** branch pattern, so queue-ref pushes no longer create a competing run; merge_group: checks_requested remains the authoritative queue run and still produces the required ci / ci-required context. The existing Code Owner review, strict required check, linear-history/deletion/force-push protections, squash-only repository setting, bypass actors, and CodeQL PR/post-merge behavior are preserved.

The remaining Copilot thread is a false positive: GitHub Actions documents that dereferencing an absent context property evaluates to an empty string, not an error (contexts reference); additionally, the openai/openai-ruby repository predicates guard the Stainless-only property accesses. No substantive issues remain.

@jbeckwith-oai
jbeckwith-oai merged commit cc5de4e into main Aug 3, 2026
15 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/enable-merge-queue branch August 3, 2026 20:55
@jbeckwith-oai jbeckwith-oai added the generator Touches generated SDK files label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generator Touches generated SDK files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants