fix(responses): correct finalResponse error message and drop duplicate spread - #2045
Closed
pouyashahrdami wants to merge 1 commit into
Closed
fix(responses): correct finalResponse error message and drop duplicate spread#2045pouyashahrdami wants to merge 1 commit into
pouyashahrdami wants to merge 1 commit into
Conversation
…e spread
- ResponseStream.finalResponse() threw/documented 'ChatCompletion' when it
returns a Response; the message was copied from the Chat Completions helper.
- Remove a redundant duplicate `...toolCall` spread in ResponsesParser's
parseToolCall (no behavioral change; {...x, ...x} equals {...x}).
Author
|
Closing in favor of #2022, which already fixes the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small fixes in the handwritten Responses helpers (
src/lib/):ResponseStream.finalResponse()reported the wrong type. When the stream ends without producing a result, it threwOpenAIError('stream ended without producing a ChatCompletion')and its JSDoc read...without producing a REsponse. This helper returns aResponse, not aChatCompletion— the message was copied from the Chat Completions helper. Corrected both the thrown message and the doc typo.Removed a redundant duplicate
...toolCallspread inResponsesParser.parseToolCall. The object literal spreadtoolCalltwice ({ ...toolCall, ...toolCall, parsed_arguments }). Spreading the same object twice is identical to spreading it once, so this is a pure no-op cleanup. It has been present since the file was first added.Why
The
ChatCompletionwording is misleading when debugging Responses streaming, and the duplicate spread is dead code.Testing
prettier --checkandeslintpass on both files.tsctypechecks cleanly.tests/lib/ResponseStream.test.tsandtests/lib/ResponsesParser*.test.tssuites pass.No behavioral change beyond the corrected error string.