Repository navigation
feat(api): add standalone Decisions support - #1148
Conversation
Castiron-Internal-PR: openai/openai-java-internal#221 Castiron-Source-SHA: f458c478469c6a691258d1e3edd25bcc69cbc87b Castiron-Public-Base-SHA: 7648554
Castiron custom codeEvaluated main: Mixed files: 93 → 102 9 newly customized · 0 customizations removed · 0 existing customizations changed · 9 generated baselines changed Compared
93 existing customizations unchanged
53 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37538038882 --repo openai/openai-java \
--name castiron-custom-code-37538038882-1 --dir /tmp/castiron-custom-code-37538038882-1
git apply --stat /tmp/castiron-custom-code-37538038882-1/custom-code.patch
cat /tmp/castiron-custom-code-37538038882-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 7648554b5e6a250a233cc11e211f436b756ef03b 7ba474e133316eef657de67c76180817cbf441ac
python3 scripts/castiron/custom_code_report.py report \
--base 7648554b5e6a250a233cc11e211f436b756ef03b \
--head 7ba474e133316eef657de67c76180817cbf441ac --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7ba474e13331
cat /tmp/castiron-custom-code-7ba474e13331/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ba474e133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -23,7 +35,7 @@ import kotlin.jvm.optionals.getOrNull | |||
| class ResponseToolSearchOutputItemParam | |||
| @JsonCreator(mode = JsonCreator.Mode.DISABLED) | |||
| private constructor( | |||
| private val tools: JsonField<List<Tool>>, | |||
| private val tools: JsonField<List<ResponseTool>>, | |||
There was a problem hiding this comment.
When a tool-search response contains a valid function with only name and type—parameters and strict are optional in the newly added output schema—this field still deserializes it as the global ResponseTool, whose FunctionTool requires both fields. Consequently, response validation or access to those fields rejects a valid server response, while the newly generated nested output Tool is never used. Wire tools to the output-specific union in both the regular and beta models, fixing the authoritative generator source rather than only the generated files.
AGENTS.md reference: AGENTS.md:L5-L8
Useful? React with 👍 / 👎.
3 participants
Summary
Create decisions with the Java client.
Changes