Repository navigation
[COMPATIBILITY] Check stdin and file workflows in WSL 1 - #461
Conversation
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 5 mixed files remain; 0 existing customizations changed. Compared 5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38514975040 --repo openai/openai-cli \
--name castiron-custom-code-38514975040-1 --dir /tmp/castiron-custom-code-38514975040-1
git apply --stat /tmp/castiron-custom-code-38514975040-1/custom-code.patch
cat /tmp/castiron-custom-code-38514975040-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 97b43f2cacc586ab352de1d544bd0b3c89936364 5a53de09078d429782bcbc04f491ddf89876cbef
python3 scripts/castiron/custom_code_report.py report \
--base 97b43f2cacc586ab352de1d544bd0b3c89936364 \
--head 5a53de09078d429782bcbc04f491ddf89876cbef --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-5a53de09078d
cat /tmp/castiron-custom-code-5a53de09078d/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The WSL job can stop on a download startup timeout before any test runs. It also covers only pager ownership.
This retries startup once and adds existing stdin, file, and output checks to the same disposable Ubuntu WSL 1 session.
What changes
Commands
Public CLI commands remain unchanged. Contributor controls run without WSL or network access:
The existing CI job builds both Linux test binaries and imports one pinned Ubuntu distro.
The runner accepts
--process-binaryfor the fixed process suite.Code
The workflow adds one test-binary build. The existing Python runner verifies and runs it inside the same owned distro.
Product code, Go tests, dependencies, and other CI jobs remain unchanged.
Tested
All 42 offline controls passed locally and on native Windows AMD64.
The native WSL job passed all 17 process tests and 104 subtests.
The existing pager test and its two subtests also passed. Payload hashes and named distro cleanup were verified.
The tested tree matches refreshed head 5a53de0. Head checks completed without failures. Conditional jobs were skipped.
The download opened on its first attempt. Retry recovery still has synthetic coverage only.
This does not establish WSL 2, ARM64 WSL, DrvFS, or Windows Terminal coverage.
Demo
There is no visible product change. CI retains separate process output, exit statuses, binary hashes, and distro cleanup results.