Skip to content

[COMPATIBILITY] Check stdin and file workflows in WSL 1 - #461

Merged
saioai merged 4 commits into
mainfrom
codex/compat-wsl-process-contracts
Oct 14, 2026
Merged

saioai merged 4 commits into
mainfrom
codex/compat-wsl-process-contracts

Conversation

@saioai

@saioai saioai commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The WSL job can stop on a download startup timeout before any test runs. It also covers only pager ownership.
This retries startup once and adds existing stdin, file, and output checks to the same disposable Ubuntu WSL 1 session.

What changes

Commands

Public CLI commands remain unchanged. Contributor controls run without WSL or network access:

python -I -B scripts/test_wsl_pager.py

The existing CI job builds both Linux test binaries and imports one pinned Ubuntu distro.
The runner accepts --process-binary for the fixed process suite.

Code

The workflow adds one test-binary build. The existing Python runner verifies and runs it inside the same owned distro.
Product code, Go tests, dependencies, and other CI jobs remain unchanged.

Tested

All 42 offline controls passed locally and on native Windows AMD64.
The native WSL job passed all 17 process tests and 104 subtests.
The existing pager test and its two subtests also passed. Payload hashes and named distro cleanup were verified.
The tested tree matches refreshed head 5a53de0. Head checks completed without failures. Conditional jobs were skipped.
The download opened on its first attempt. Retry recovery still has synthetic coverage only.
This does not establish WSL 2, ARM64 WSL, DrvFS, or Windows Terminal coverage.

Demo

There is no visible product change. CI retains separate process output, exit statuses, binary hashes, and distro cleanup results.

Comment thread scripts/check-wsl-pager.py Fixed
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Castiron custom code

Evaluated main: 97b43f2cacc586ab352de1d544bd0b3c89936364.

✅ No new custom-code files detected.

5 mixed files remain; 0 existing customizations changed.

Compared 97b43f2cacc5 → 5a53de09078d. Generated baselines verified.

5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/audiovoice.go
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_budget.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38514975040 --repo openai/openai-cli \
  --name castiron-custom-code-38514975040-1 --dir /tmp/castiron-custom-code-38514975040-1
git apply --stat /tmp/castiron-custom-code-38514975040-1/custom-code.patch
cat /tmp/castiron-custom-code-38514975040-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 97b43f2cacc586ab352de1d544bd0b3c89936364 5a53de09078d429782bcbc04f491ddf89876cbef
python3 scripts/castiron/custom_code_report.py report \
  --base 97b43f2cacc586ab352de1d544bd0b3c89936364 \
  --head 5a53de09078d429782bcbc04f491ddf89876cbef --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-5a53de09078d
cat /tmp/castiron-custom-code-5a53de09078d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@saioai
saioai marked this pull request as ready for review October 14, 2026 04:28
@saioai
saioai requested a review from a team as a code owner October 14, 2026 04:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T04:56:38.139787Z 5a53de0 New commits
🔒 Security Review ✅ Completed 2026-10-14T04:57:27.276050Z 5a53de0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@saioai
saioai added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 09c4d9e Oct 14, 2026
32 checks passed
@saioai
saioai deleted the codex/compat-wsl-process-contracts branch October 14, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants